Fix links and update event typings #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
egilmorez,
Feiyang1 and
hiranya911
as code owners
🦋 Changeset detectedLatest commit: 9cdbf4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check
|
hsubox76
assigned kevinthecheung and egilmorez and unassigned egilmorez and kevinthecheung
Feiyang1
reviewed
Jul 28, 2021
Feiyang1
approved these changes
Jul 29, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some link formatting in comments, addressing #5116.
While doing that, discovered some of the links were for UA and not for GA4, meaning some of the event/config params were incorrect. Corrected them.
The link for screenviews (https://firebase.google.com/docs/analytics/screenviews) doesn't have the JS snippet yet, it can't be submitted until the typing changes in this PR have been released. It should be a short lag time though.