Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppCheck typings error #5261

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Fix AppCheck typings error #5261

merged 2 commits into from
Aug 10, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Aug 9, 2021

Incorrect typing of activate() params in packages/firebase/index.d.ts is causing users to get Typescript errors when using string or provider arguments.

Fixes #5258

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2021

🦋 Changeset detected

Latest commit: f2762ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/app-check Patch
@firebase/app-check-types Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 9, 2021

Binary Size Report

Affected SDKs

No changes between base commit (8893c82) and head commit (65fc368).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 9, 2021

Size Analysis Report

Affected Products

No changes between base commit (8893c82) and head commit (65fc368).

@hsubox76 hsubox76 merged commit f1027e3 into master Aug 10, 2021
@hsubox76 hsubox76 deleted the ch-appcheck-type-fix branch August 10, 2021 16:51
@google-oss-bot google-oss-bot mentioned this pull request Aug 10, 2021
@firebase firebase locked and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReCaptchaV3Provider Typescript
3 participants