Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run LRU even if multi-tab is disabled #5288

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

We somehow managed to move the LRU scheduling code from the IndexedDbComponentProvider to the MultiTabComponentProvider, which means that right now, LRU GC only runs when multi-tab is enabled. This fixes this.

Unfortunately, we do not have any testing infrastructure that can check this automatically. I manually tested this change in a test app.

Fixes b/194762991

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2021

🦋 Changeset detected

Latest commit: ee12bb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 12, 2021

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (2c90aec) Head (f056cd1) Diff
    browser 285 kB 285 kB +245 B (+0.1%)
    esm2017 227 kB 227 kB +138 B (+0.1%)
    main 531 kB 531 kB +215 B (+0.0%)
    module 285 kB 285 kB +245 B (+0.1%)
    react-native 227 kB 227 kB +138 B (+0.1%)
  • @firebase/firestore-exp

    Type Base (2c90aec) Head (f056cd1) Diff
    browser 225 kB 225 kB +138 B (+0.1%)
    main 511 kB 511 kB +215 B (+0.0%)
    module 225 kB 225 kB +138 B (+0.1%)
    react-native 225 kB 225 kB +138 B (+0.1%)
  • @firebase/firestore/bundle

    Type Base (2c90aec) Head (f056cd1) Diff
    browser 291 kB 291 kB +171 B (+0.1%)
    main 527 kB 527 kB +215 B (+0.0%)
    module 291 kB 291 kB +171 B (+0.1%)
  • firebase

    Type Base (2c90aec) Head (f056cd1) Diff
    firebase-firestore.js 337 kB 337 kB +169 B (+0.1%)
    firebase.js 895 kB 896 kB +169 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 12, 2021

Size Analysis Report

Affected Products

No changes between base commit (2c90aec) and head commit (f056cd1).

@schmidt-sebastian schmidt-sebastian merged commit f825b1d into master Aug 17, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/gcfix branch August 17, 2021 16:38
@google-oss-bot google-oss-bot mentioned this pull request Aug 17, 2021
@firebase firebase locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants