Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Auth internal types from the public typings #5460

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Sep 8, 2021

Fixes #5451

Mark some internal types as @internal to prevent const enums from accidentally showing up in the public typing file.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2021

🦋 Changeset detected

Latest commit: e3d059e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Feiyang1
Copy link
Member Author

Feiyang1 commented Sep 8, 2021

@sam-gc FYI

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of this Fei

@Feiyang1 Feiyang1 merged commit 271303f into master Sep 8, 2021
@Feiyang1 Feiyang1 deleted the fei-auth-const-enums branch September 8, 2021 22:44
@google-oss-bot google-oss-bot mentioned this pull request Sep 9, 2021
@firebase firebase locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug still exists: Stop using const enums in the public API #5012
3 participants