Temporary hack to fix terser output #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78fab00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Feiyang1
reviewed
Sep 8, 2021
| // bundlers (Babel?) to confuse the same variable name in different scopes. | ||
| // This can be removed if the problem in the downstream library is fixed | ||
| // or if terser's mangler provides an option to avoid mangling everything | ||
| // that isn't a property. |
There was a problem hiding this comment.
probably worth adding the issue link for future reference.
There was a problem hiding this comment.
We have two lists of reserved properties now (see right below - line 158). Do we know that this will work?
Feiyang1
approved these changes
Sep 8, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mangled terser code is causing some problems seen in Create React App apps. This is a temporary fix that will avoid mangling the specific variable in question. Long term fix is to see if terser will provide an option to mangle properties without mangling anything else (currently not available), and/or find out what downstream build tool is causing this bug and get them to fix it.
Details:
The
initializeFirestore()function, when mangled by terser, has two variables with the same name in different scopes (one is an import, one is aconstin anifblock). This seems to confuse one of the tools in the Create React App production default build pipeline (Babel?). The code is converted to ES5, which makes theconstavar, which puts both variables sharing a name into the same scope. The build tool gets confused and does not convert the import to the correct symbol, thinking it is the same as the declaredvar. We should try to pinpoint what step of the build this happens in and report a bug to the appropriate library.Fixes #5384