Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Switch compat UserCredential function to use promise chaining instead of async/await #5562

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Sep 30, 2021

Hopefully to address b/198623196

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2021

🦋 Changeset detected

Latest commit: 19cc907

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth-compat Patch
@firebase/auth Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 30, 2021

Binary Size Report

Affected SDKs

  • @firebase/auth-compat

    Type Base (91117e0) Head (b73c5eb) Diff
    browser 19.7 kB 19.7 kB +8 B (+0.0%)
    esm5 26.8 kB 26.6 kB -199 B (-0.7%)
    main 29.3 kB 29.1 kB -211 B (-0.7%)
    module 19.7 kB 19.7 kB +8 B (+0.0%)
  • firebase

    Type Base (91117e0) Head (b73c5eb) Diff
    firebase-auth-compat.js 122 kB 122 kB -2 B (-0.0%)
    firebase-compat.js 748 kB 748 kB -2 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 30, 2021

Size Analysis Report

Affected Products

No changes between base commit (91117e0) and head commit (b73c5eb).

@sam-gc sam-gc merged commit f7d8324 into master Sep 30, 2021
@sam-gc sam-gc deleted the sam-gc/user_credential branch September 30, 2021 23:32
@google-oss-bot google-oss-bot mentioned this pull request Oct 5, 2021
@eiiot
Copy link

eiiot commented Oct 8, 2021

Still facing this issue using Web V8 (9.1.2).

Using:
<script defer src="/__/firebase/9.1.2/firebase-auth-compat.js"></script>

Error is the same.
Unhandled Promise Rejection: TypeError: Right side of assignment cannot be destructured

@sam-gc
Copy link
Contributor Author

sam-gc commented Oct 21, 2021

@eliot this appears to be fixed in 9.1.2. Regardless, try upgrading to 9.1.3 and seeing if you still see the issue. If you are, please file a new issue in the repo.

@firebase firebase locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants