Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app-check-compat providers #5573

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Fix app-check-compat providers #5573

merged 3 commits into from
Oct 5, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 4, 2021

Not sure how this was overlooked but the special provider classes were not exported on the firebase.appcheck object and activate was not set up to process them.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2021 •
edited

🦋 Changeset detected

Latest commit: ec9c080

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/app-check-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 4, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 4, 2021 •
edited

Binary Size Report

Affected SDKs

  • @firebase/app-check-compat

    Type Base (49dfeb3) Head (9896145) Diff
    browser 1.91 kB 2.13 kB +219 B (+11.5%)
    esm5 2.11 kB 2.33 kB +219 B (+10.4%)
    main 2.56 kB 2.81 kB +255 B (+10.0%)
    module 1.91 kB 2.13 kB +219 B (+11.5%)

  • firebase

    Type Base (49dfeb3) Head (9896145) Diff
    firebase-app-check-compat.js 19.8 kB 19.9 kB +95 B (+0.5%)
    firebase-compat.js 748 kB 748 kB +95 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 4, 2021 •
edited

Size Analysis Report

Affected Products

No changes between base commit (49dfeb3) and head commit (9896145).

Feiyang1
Feiyang1 reviewed Oct 5, 2021
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changeset

packages/app-check-compat/src/service.test.ts Show resolved Hide resolved
@hsubox76
Copy link
Contributor Author

hsubox76 commented Oct 5, 2021

Changeset added.

@hsubox76 hsubox76 assigned Feiyang1 and unassigned hsubox76 Oct 5, 2021
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Oct 5, 2021
@hsubox76 hsubox76 merged commit 3e920c8 into master Oct 5, 2021
@hsubox76 hsubox76 deleted the ch-appcheck-compat-fix branch October 5, 2021 18:22
@google-oss-bot google-oss-bot mentioned this pull request Oct 5, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@hsubox76 hsubox76

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsubox76 @google-oss-bot @Feiyang1