Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Fix OAuth credential issue with nonce fields #5574

Merged
merged 2 commits into from
Oct 5, 2021
Merged

[Auth] Fix OAuth credential issue with nonce fields #5574

merged 2 commits into from
Oct 5, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Oct 4, 2021

Fixes #5553

The field wasn't being carried through to the final object properly. This change also makes the nonce field in the OAuthCredential object fully private---it is not documented or exposed in any of the other SDKs

@sam-gc sam-gc requested a review from yuchenshi October 4, 2021 21:28
@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2021 •
edited

🦋 Changeset detected

Latest commit: 1265b70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 4, 2021
@sam-gc sam-gc requested a review from egilmorez as a code owner October 4, 2021 21:33
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 4, 2021 •
edited

Binary Size Report

Affected SDKs

  • @firebase/auth/cordova

    Type Base (49dfeb3) Head (0bae951) Diff
    browser 178 kB 178 kB +189 B (+0.1%)
    module 178 kB 178 kB +189 B (+0.1%)

  • @firebase/auth/internal

    Type Base (49dfeb3) Head (0bae951) Diff
    browser 162 kB 162 kB +199 B (+0.1%)
    esm5 210 kB 211 kB +189 B (+0.1%)
    main 178 kB 178 kB +205 B (+0.1%)
    module 162 kB 162 kB +199 B (+0.1%)

  • @firebase/auth/react-native

    Type Base (49dfeb3) Head (0bae951) Diff
    browser 143 kB 143 kB +205 B (+0.1%)
    module 143 kB 143 kB +205 B (+0.1%)

  • firebase

    Type Base (49dfeb3) Head (0bae951) Diff
    firebase-auth-compat.js 122 kB 122 kB +170 B (+0.1%)
    firebase-auth-cordova.js 459 kB 459 kB +249 B (+0.1%)
    firebase-auth-react-native.js 430 kB 430 kB +265 B (+0.1%)
    firebase-auth.js 409 kB 409 kB +252 B (+0.1%)
    firebase-compat.js 748 kB 748 kB +170 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 4, 2021 •
edited

Size Analysis Report

Affected Products

  • @firebase/auth

    • FacebookAuthProvider

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      34.8 kB
      34.9 kB
      +121 B (+0.3%)
      size-with-ext-deps
      46.6 kB
      46.7 kB
      +121 B (+0.3%)

    • GithubAuthProvider

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      34.8 kB
      34.9 kB
      +121 B (+0.3%)
      size-with-ext-deps
      46.6 kB
      46.7 kB
      +121 B (+0.3%)

    • GoogleAuthProvider

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      34.8 kB
      34.9 kB
      +121 B (+0.3%)
      size-with-ext-deps
      46.6 kB
      46.7 kB
      +121 B (+0.3%)

    • OAuthCredential

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      31.9 kB
      32.0 kB
      +121 B (+0.4%)
      size-with-ext-deps
      43.7 kB
      43.8 kB
      +121 B (+0.3%)

    • OAuthProvider

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      35.6 kB
      35.8 kB
      +170 B (+0.5%)
      size-with-ext-deps
      47.5 kB
      47.7 kB
      +170 B (+0.4%)

    • SAMLAuthProvider

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      36.0 kB
      36.1 kB
      +121 B (+0.3%)
      size-with-ext-deps
      47.9 kB
      48.0 kB
      +121 B (+0.3%)

    • TwitterAuthProvider

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      34.8 kB
      34.9 kB
      +121 B (+0.3%)
      size-with-ext-deps
      46.6 kB
      46.7 kB
      +121 B (+0.3%)

    • getAuth

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      61.3 kB
      61.5 kB
      +121 B (+0.2%)
      size-with-ext-deps
      73.8 kB
      74.0 kB
      +121 B (+0.2%)

    • linkWithPopup

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      40.8 kB
      41.0 kB
      +121 B (+0.3%)
      size-with-ext-deps
      52.7 kB
      52.8 kB
      +121 B (+0.2%)

    • linkWithRedirect

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      36.0 kB
      36.1 kB
      +121 B (+0.3%)
      size-with-ext-deps
      47.9 kB
      48.0 kB
      +121 B (+0.3%)

    • reauthenticateWithPopup

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      40.9 kB
      41.0 kB
      +121 B (+0.3%)
      size-with-ext-deps
      52.7 kB
      52.8 kB
      +121 B (+0.2%)

    • reauthenticateWithRedirect

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      35.8 kB
      35.9 kB
      +121 B (+0.3%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +121 B (+0.3%)

    • signInWithPopup

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      40.8 kB
      40.9 kB
      +121 B (+0.3%)
      size-with-ext-deps
      52.7 kB
      52.8 kB
      +121 B (+0.2%)

    • signInWithRedirect

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      35.5 kB
      35.6 kB
      +121 B (+0.3%)
      size-with-ext-deps
      47.3 kB
      47.5 kB
      +121 B (+0.3%)

    • browserPopupRedirectResolver

      Size Table

      TypeBase (49dfeb3)Head (0bae951)Diff
      size
      53.6 kB
      53.7 kB
      +121 B (+0.2%)
      size-with-ext-deps
      65.7 kB
      65.8 kB
      +121 B (+0.2%)

@Feiyang1 Feiyang1 assigned sam-gc and unassigned Feiyang1 Oct 5, 2021
@sam-gc sam-gc merged commit e1d551d into master Oct 5, 2021
@sam-gc sam-gc deleted the sam-gc/oauth branch October 5, 2021 17:50
@google-oss-bot google-oss-bot mentioned this pull request Oct 5, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@egilmorez egilmorez Awaiting requested review from egilmorez

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees

@sam-gc sam-gc

@hsubox76 hsubox76

@lisajian lisajian

@yuchenshi yuchenshi

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rawNonce missing from credential - Firebase Auth v9
6 participants
@sam-gc @google-oss-bot @Feiyang1 @lisajian @yuchenshi @hsubox76