Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Fix getRedirectResult behavior #5617

Merged
merged 3 commits into from
Oct 14, 2021
Merged

[Auth] Fix getRedirectResult behavior #5617

merged 3 commits into from
Oct 14, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Oct 14, 2021 •
edited

Fixes #5610

After the initial (user) call to getRedirectResult(), subsequent calls should return null

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2021 •
edited

🦋 Changeset detected

Latest commit: b09011f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth-compat Minor
@firebase/auth Minor
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 14, 2021 •
edited

Binary Size Report

Affected SDKs

  • @firebase/auth/cordova

    Type Base (5a9a144) Head (c974fe9) Diff
    browser 178 kB 178 kB +110 B (+0.1%)
    module 178 kB 178 kB +110 B (+0.1%)

  • @firebase/auth/internal

    Type Base (5a9a144) Head (c974fe9) Diff
    browser 163 kB 163 kB +95 B (+0.1%)
    esm5 211 kB 211 kB +110 B (+0.1%)
    main 178 kB 178 kB +110 B (+0.1%)
    module 163 kB 163 kB +95 B (+0.1%)

  • firebase

    Type Base (5a9a144) Head (c974fe9) Diff
    firebase-auth-compat.js 122 kB 122 kB +73 B (+0.1%)
    firebase-auth-cordova.js 459 kB 460 kB +356 B (+0.1%)
    firebase-auth.js 409 kB 410 kB +233 B (+0.1%)
    firebase-compat.js 749 kB 749 kB +73 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 14, 2021 •
edited

Size Analysis Report

Affected Products

  • @firebase/auth

    • getAuth

      Size Table

      TypeBase (5a9a144)Head (bc5aba0)Diff
      size
      61.5 kB
      61.6 kB
      +79 B (+0.1%)
      size-with-ext-deps
      74.0 kB
      74.1 kB
      +79 B (+0.1%)

    • getRedirectResult

      Size Table

      TypeBase (5a9a144)Head (bc5aba0)Diff
      size
      37.3 kB
      37.4 kB
      +79 B (+0.2%)
      size-with-ext-deps
      49.2 kB
      49.3 kB
      +79 B (+0.2%)

    • browserPopupRedirectResolver

      Size Table

      TypeBase (5a9a144)Head (bc5aba0)Diff
      size
      53.8 kB
      53.9 kB
      +79 B (+0.1%)
      size-with-ext-deps
      65.9 kB
      65.9 kB
      +79 B (+0.1%)

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Oct 14, 2021
@sam-gc sam-gc merged commit b6f30c2 into master Oct 14, 2021
@sam-gc sam-gc deleted the sam-gc/redirect-result branch October 14, 2021 19:45
This was referenced Oct 19, 2021
Merged
Merged
@sam-gc sam-gc mentioned this pull request Nov 1, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@egilmorez egilmorez

@lisajian lisajian

@yuchenshi yuchenshi

Labels
cla: yes doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
5 participants
@sam-gc @google-oss-bot @yuchenshi @egilmorez @lisajian