Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Make auth resilient against localStorage and sessionStorage permissions errors #5635

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Oct 19, 2021

Fixes #5618.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2021

🦋 Changeset detected

Latest commit: 8ea95e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2021

Binary Size Report

Affected SDKs

  • @firebase/auth/cordova

    Type Base (05773dc) Head (00fbde7) Diff
    browser 178 kB 179 kB +313 B (+0.2%)
    module 178 kB 179 kB +313 B (+0.2%)
  • @firebase/auth/internal

    Type Base (05773dc) Head (00fbde7) Diff
    browser 163 kB 163 kB +147 B (+0.1%)
    esm5 211 kB 211 kB +313 B (+0.1%)
    main 178 kB 179 kB +313 B (+0.2%)
    module 163 kB 163 kB +147 B (+0.1%)
  • firebase

    Type Base (05773dc) Head (00fbde7) Diff
    firebase-auth-compat.js 122 kB 122 kB +117 B (+0.1%)
    firebase-auth-cordova.js 460 kB 460 kB +558 B (+0.1%)
    firebase-auth.js 410 kB 410 kB +206 B (+0.1%)
    firebase-compat.js 749 kB 749 kB +117 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2021

Size Analysis Report

Affected Products

  • @firebase/auth

    • getAuth

      Size Table

      TypeBase (05773dc)Head (00fbde7)Diff
      size
      61.6 kB
      61.7 kB
      +113 B (+0.2%)
      size-with-ext-deps
      74.1 kB
      74.3 kB
      +113 B (+0.2%)
    • getRedirectResult

      Size Table

      TypeBase (05773dc)Head (00fbde7)Diff
      size
      37.4 kB
      37.4 kB
      +47 B (+0.1%)
      size-with-ext-deps
      49.3 kB
      49.3 kB
      +47 B (+0.1%)
    • browserLocalPersistence

      Size Table

      TypeBase (05773dc)Head (00fbde7)Diff
      size
      33.1 kB
      33.1 kB
      +66 B (+0.2%)
      size-with-ext-deps
      45.0 kB
      45.1 kB
      +66 B (+0.1%)
    • browserPopupRedirectResolver

      Size Table

      TypeBase (05773dc)Head (00fbde7)Diff
      size
      53.9 kB
      54.0 kB
      +113 B (+0.2%)
      size-with-ext-deps
      66.0 kB
      66.1 kB
      +113 B (+0.2%)
    • browserSessionPersistence

      Size Table

      TypeBase (05773dc)Head (00fbde7)Diff
      size
      33.1 kB
      33.1 kB
      +66 B (+0.2%)
      size-with-ext-deps
      45.0 kB
      45.1 kB
      +66 B (+0.1%)

@sam-gc sam-gc merged commit 6dacc24 into master Oct 20, 2021
@sam-gc sam-gc deleted the sam-gc/cookies branch October 20, 2021 21:56
@google-oss-bot google-oss-bot mentioned this pull request Oct 27, 2021
@firebase firebase locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v9 modular: firebase getAuth method throwing error if cookies are disabled by browser (no localStorage)
4 participants