Add getBytes() #5672
Merged
Add getBytes() #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d119bfb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
…sdk into mrschmidt/getbytes
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis ReportAffected Products
|
Feiyang1
reviewed
Nov 9, 2021
| * Cloud Storage bucket. See also | ||
| * https://cloud.google.com/storage/docs/configuring-cors | ||
| * | ||
| * @public |
There was a problem hiding this comment.
@egilmorez can you please scan the PR and review the comments with the @public tag? Thanks!
There was a problem hiding this comment.
I was hoping @markarndt could give that a go . . . but if he's too busy and there's urgency, I can take a look this afternoon for sure.
Co-authored-by: Feiyang <feiyangc@google.com>
Co-authored-by: Feiyang <feiyangc@google.com>
Co-authored-by: Feiyang <feiyangc@google.com>
Co-authored-by: Feiyang <feiyangc@google.com>
…sdk into mrschmidt/getbytes
Feiyang1
reviewed
Nov 9, 2021
Feiyang1
reviewed
Nov 9, 2021
| @@ -100,6 +100,27 @@ describeSpec('Queries:', [], () => { | |||
| }); | |||
| }); | |||
|
|
|||
| Caused by: java.lang.AssertionError: expected:< | |||
There was a problem hiding this comment.
This .... ehmm... seems unrelated. Removed.
Co-authored-by: Feiyang <feiyangc@google.com>
…sdk into mrschmidt/getbytes
| @@ -100,6 +100,27 @@ describeSpec('Queries:', [], () => { | |||
| }); | |||
| }); | |||
|
|
|||
| Caused by: java.lang.AssertionError: expected:< | |||
There was a problem hiding this comment.
This .... ehmm... seems unrelated. Removed.
Feiyang1
approved these changes
Nov 10, 2021
…sdk into mrschmidt/getbytes
markarndt
reviewed
Nov 10, 2021
packages/storage/src/api.ts
Outdated
| * https://cloud.google.com/storage/docs/configuring-cors | ||
| * | ||
| * @public | ||
| * @param ref - StorageReference where data should be download. |
There was a problem hiding this comment.
"..should be downloaded."
markarndt
approved these changes
Nov 10, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds getBytes, getBlob and getStream APIs which allows file downloads without a public download URL. These bytes can then be used directly as an image source.
This PR contains a bunch of refactors to make this possible:
Connection<string>,Connection<ArrayBuffer>andConnection<ReadableStream>.Fixes #76