Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone symbols to react native export #5673

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Add phone symbols to react native export #5673

merged 3 commits into from
Oct 27, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Oct 27, 2021

Quick patch for #5638

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2021

🦋 Changeset detected

Latest commit: 6f3b44b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 27, 2021
Copy link
Contributor

@lisajian lisajian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this need a changeset?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2021

Binary Size Report

Affected SDKs

  • @firebase/auth/react-native

    Type Base (dfed7f8) Head (2e432fd) Diff
    browser 143 kB 162 kB +19.2 kB (+13.4%)
    module 143 kB 162 kB +19.2 kB (+13.4%)
  • firebase

    Type Base (dfed7f8) Head (2e432fd) Diff
    firebase-auth-react-native.js 430 kB 479 kB +48.7 kB (+11.3%)
    firebase-auth.js 410 kB 410 kB +203 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2021

Size Analysis Report

Affected Products

No changes between base commit (dfed7f8) and head commit (2e432fd).

@sam-gc sam-gc merged commit 4594d3f into master Oct 27, 2021
@sam-gc sam-gc deleted the sam-gc/rn-phone branch October 27, 2021 22:12
@google-oss-bot google-oss-bot mentioned this pull request Oct 27, 2021
@firebase firebase locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants