Add retry logic to app check #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hsubox76
commented
Oct 28, 2021
hsubox76
commented
- Block exchange requests for certain periods of time on certain error codes
- 400, 404: 1 day
- Other error codes: exponential backoff
- Fix bugs causing duplicate calls to listeners
- Do not make multiple requests to exchange endpoint if a request is already in flight
- Start a token listener when App Check is initialized to avoid extra wait time on first getToken() call
🦋 Changeset detectedLatest commit: 5e0d22b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
hsubox76
force-pushed
the
ch-appcheck-retry
branch
from
a6be820
to
c954452
Compare
hsubox76
changed the title
Feiyang1
reviewed
Nov 9, 2021
packages/app-check/src/providers.ts
Outdated
Comment on lines
68
to
75
| if (!this._app || !this._platformLoggerProvider) { | ||
| // This should only occur if user has not called initializeAppCheck(). | ||
| // We don't have an appName to provide if so. | ||
| // This should already be caught in the top level `getToken()` function. | ||
| throw ERROR_FACTORY.create(AppCheckError.USE_BEFORE_ACTIVATION, { | ||
| appName: '' | ||
| }); | ||
| } |
There was a problem hiding this comment.
I think we discussed it in another PR that we don't need this check and can assume the 2 properties are available.
There was a problem hiding this comment.
Yes, looks like it was merged with the recaptcha enterprise PR, I'll rebase. I also need to add all this functionality for recaptcha enterprise.
hsubox76
force-pushed
the
ch-appcheck-retry
branch
from
c395be3
to
7ca267e
Compare
|
Also rebased and added recaptcha enterprise changes. |
Feiyang1
reviewed
Nov 11, 2021
Feiyang1
approved these changes
Nov 12, 2021
kevinthecheung
approved these changes
Nov 12, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.