better meta url polyfill #5738

Feiyang1 · 2021-11-16T19:43:00Z

Generate polyfill for Nodejs only.
Partially fixes #5687 (or rather just hide the problem that Jest will load Nodejs bundles as if it is testing in browser)

changeset-bot · 2021-11-16T19:43:04Z

🦋 Changeset detected

Latest commit: 48ffb4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2021-11-16T20:27:28Z

Size Analysis Report

Affected Products

`@firebase/app-check`

`CustomProvider`

Size Table

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
size	7.24 kB	7.47 kB	+230 B (+3.2%)
size-with-ext-deps	16.9 kB	17.1 kB	+233 B (+1.4%)

Dependency Table

Type Base (acc5810) Head (b9e890e) Diff

functions

20 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ initTokenRefresher

`ReCaptchaEnterpriseProvider`

Size Table

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
size	9.51 kB	10.9 kB	+1.39 kB (+14.7%)
size-with-ext-deps	18.7 kB	20.3 kB	+1.55 kB (+8.3%)

Dependency Table

Type Base (acc5810) Head (b9e890e) Diff

functions

29 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getExchangeRecaptchaEnterpriseTokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initializeEnterprise
internalFactory
isValid
loadReCAPTCHAEnterpriseScript
makeDiv
makeDummyTokenResult
notifyTokenListeners
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

34 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDurationString
getExchangeRecaptchaEnterpriseTokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initTokenRefresher
initializeEnterprise
internalFactory
isValid
loadReCAPTCHAEnterpriseScript
makeDiv
makeDummyTokenResult
notifyTokenListeners
pad
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setBackoff
setState
sleep
throwIfThrottled
write
writeTokenToIndexedDB
writeTokenToStorage

+ getDurationString
+ initTokenRefresher
+ pad
+ setBackoff
+ throwIfThrottled

variables

18 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_ENTERPRISE_TOKEN_METHOD
RECAPTCHA_ENTERPRISE_URL
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

19 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_ENTERPRISE_TOKEN_METHOD
ONE_DAY
RECAPTCHA_ENTERPRISE_URL
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

+ ONE_DAY

External Dependency Table

Module	Base (`acc5810`)	Head (`b9e890e`)	Diff
`@firebase/util`	Deferred ErrorFactory base64 isIndexedDBAvailable	Deferred ErrorFactory base64 calculateBackoffMillis isIndexedDBAvailable	+ calculateBackoffMillis

`ReCaptchaV3Provider`

Size Table

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
size	9.48 kB	10.9 kB	+1.39 kB (+14.7%)
size-with-ext-deps	18.7 kB	20.2 kB	+1.55 kB (+8.3%)

Dependency Table

Type Base (acc5810) Head (b9e890e) Diff

functions

29 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getExchangeRecaptchaV3TokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initializeV3
internalFactory
isValid
loadReCAPTCHAV3Script
makeDiv
makeDummyTokenResult
notifyTokenListeners
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

34 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDurationString
getExchangeRecaptchaV3TokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initTokenRefresher
initializeV3
internalFactory
isValid
loadReCAPTCHAV3Script
makeDiv
makeDummyTokenResult
notifyTokenListeners
pad
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setBackoff
setState
sleep
throwIfThrottled
write
writeTokenToIndexedDB
writeTokenToStorage

+ getDurationString
+ initTokenRefresher
+ pad
+ setBackoff
+ throwIfThrottled

variables

18 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_TOKEN_METHOD
RECAPTCHA_URL
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

19 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_TOKEN_METHOD
ONE_DAY
RECAPTCHA_URL
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

+ ONE_DAY

External Dependency Table

Module	Base (`acc5810`)	Head (`b9e890e`)	Diff
`@firebase/util`	Deferred ErrorFactory base64 isIndexedDBAvailable	Deferred ErrorFactory base64 calculateBackoffMillis isIndexedDBAvailable	+ calculateBackoffMillis

`getToken`

Size Table

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
size	6.87 kB	7.10 kB	+230 B (+3.3%)
size-with-ext-deps	16.0 kB	16.3 kB	+233 B (+1.5%)

Dependency Table

Type Base (acc5810) Head (b9e890e) Diff

functions

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken
getToken$2
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

22 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ initTokenRefresher

`initializeAppCheck`

Size Table

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
size	10.6 kB	11.0 kB	+449 B (+4.3%)
size-with-ext-deps	20.1 kB	20.6 kB	+453 B (+2.3%)

Dependency Table

Type Base (acc5810) Head (b9e890e) Diff

functions

35 dependencies

_activate
addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDebugState
getDebugToken
getExchangeDebugTokenRequest
getState
getToken$2
initializeAppCheck
initializeDebugMode
internalFactory
isDebugMode
isValid
makeDummyTokenResult
notifyTokenListeners
read
readDebugTokenFromIndexedDB
readOrCreateDebugTokenFromStorage
readTokenFromIndexedDB
readTokenFromStorage
registerAppCheck
removeTokenListener
setState
sleep
uuidv4
write
writeDebugTokenToIndexedDB
writeTokenToIndexedDB
writeTokenToStorage

36 dependencies

_activate
addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDebugState
getDebugToken
getExchangeDebugTokenRequest
getState
getToken$2
initTokenRefresher
initializeAppCheck
initializeDebugMode
internalFactory
isDebugMode
isValid
makeDummyTokenResult
notifyTokenListeners
read
readDebugTokenFromIndexedDB
readOrCreateDebugTokenFromStorage
readTokenFromIndexedDB
readTokenFromStorage
registerAppCheck
removeTokenListener
setState
sleep
uuidv4
write
writeDebugTokenToIndexedDB
writeTokenToIndexedDB
writeTokenToStorage

+ initTokenRefresher

`onTokenChanged`

Size Table

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
size	6.97 kB	7.20 kB	+230 B (+3.3%)
size-with-ext-deps	16.1 kB	16.4 kB	+233 B (+1.4%)

Dependency Table

Type Base (acc5810) Head (b9e890e) Diff

functions

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
onTokenChanged
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

22 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
onTokenChanged
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ initTokenRefresher

`setTokenAutoRefreshEnabled`

Size Table

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
size	7.00 kB	7.23 kB	+230 B (+3.3%)
size-with-ext-deps	16.2 kB	16.4 kB	+233 B (+1.4%)

Dependency Table

Type Base (acc5810) Head (b9e890e) Diff

functions

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
setTokenAutoRefreshEnabled
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

22 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
setTokenAutoRefreshEnabled
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ initTokenRefresher

Test Logs

hsubox76 · 2021-11-16T21:59:55Z

packages/firestore/rollup.config.js

+    resolveImportMeta(property, { moduleId }) {
+      if (property === 'url') {
+        // copied from rollup output
+        return `new (require('u' + 'rl').URL)('file:' + __filename).href`;


what does separating the string do?

It's what rollup outputs. I don't think it matters though. Updated

google-oss-bot · 2021-11-17T06:28:59Z

Binary Size Report

Affected SDKs

`@firebase/app-check`

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
browser	22.3 kB	25.1 kB	+2.80 kB (+12.5%)
esm5	26.6 kB	29.7 kB	+3.05 kB (+11.4%)
main	27.8 kB	30.9 kB	+3.03 kB (+10.9%)
module	22.3 kB	25.1 kB	+2.80 kB (+12.5%)

@firebase/firestore

Type Base (acc5810) Head (b9e890e) Diff

main 423 kB 423 kB -541 B (-0.1%)

`bundle`

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
app-check (CustomProvider)	26.9 kB	27.4 kB	+453 B (+1.7%)
app-check (ReCaptchaEnterpriseProvider)	27.8 kB	29.6 kB	+1.77 kB (+6.3%)
app-check (ReCaptchaV3Provider)	27.8 kB	29.6 kB	+1.77 kB (+6.4%)

`firebase`

Type	Base (`acc5810`)	Head (`b9e890e`)	Diff
firebase-app-check-compat.js	20.8 kB	22.7 kB	+1.90 kB (+9.1%)
firebase-app-check.js	80.4 kB	89.8 kB	+9.41 kB (+11.7%)
firebase-compat.js	749 kB	751 kB	+1.81 kB (+0.2%)

Test Logs

Base (acc58102): https://github.com/firebase/firebase-js-sdk/actions/runs/1455109032
Head (b9e890eb): https://github.com/firebase/firebase-js-sdk/actions/runs/1472884056

schmidt-sebastian

FYI I don't think I have enough context to provide a meaningful review. Please ping me if you need input.

better meta url polyfill

e97c6c0

google-cla bot added the cla: yes label Nov 16, 2021

Feiyang1 assigned schmidt-sebastian and hsubox76 Nov 16, 2021

hsubox76 reviewed Nov 16, 2021

View reviewed changes

Create quick-experts-shave.md

3f91c35

Feiyang1 requested a review from egilmorez as a code owner November 17, 2021 06:10

schmidt-sebastian reviewed Nov 17, 2021

View reviewed changes

update

48ffb4e

hsubox76 approved these changes Nov 17, 2021

View reviewed changes

Feiyang1 merged commit ce39a1a into master Nov 17, 2021

Feiyang1 deleted the fei-require branch November 17, 2021 19:43

google-oss-bot mentioned this pull request Nov 17, 2021

Version Packages #5742

Merged

firebase locked and limited conversation to collaborators Dec 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

better meta url polyfill #5738

better meta url polyfill #5738

Feiyang1 commented Nov 16, 2021 •

edited

changeset-bot bot commented Nov 16, 2021 •

edited

google-oss-bot commented Nov 16, 2021 •

edited

Affected Products

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

Test Logs

hsubox76 Nov 16, 2021

Feiyang1 Nov 17, 2021

google-oss-bot commented Nov 17, 2021 •

edited

`@firebase/app-check`

`@firebase/firestore`

`bundle`

`firebase`

schmidt-sebastian left a comment

better meta url polyfill #5738

better meta url polyfill #5738

Conversation

Feiyang1 commented Nov 16, 2021 • edited

changeset-bot bot commented Nov 16, 2021 • edited

🦋 Changeset detected

google-oss-bot commented Nov 16, 2021 • edited

Size Analysis Report

Affected Products

@firebase/app-check

CustomProvider

ReCaptchaEnterpriseProvider

ReCaptchaV3Provider

getToken

initializeAppCheck

onTokenChanged

setTokenAutoRefreshEnabled

Test Logs

hsubox76 Nov 16, 2021

Choose a reason for hiding this comment

Feiyang1 Nov 17, 2021

Choose a reason for hiding this comment

google-oss-bot commented Nov 17, 2021 • edited

Binary Size Report

Affected SDKs

@firebase/app-check

@firebase/firestore

bundle

firebase

Test Logs

schmidt-sebastian left a comment

Choose a reason for hiding this comment

Feiyang1 commented Nov 16, 2021 •

edited

changeset-bot bot commented Nov 16, 2021 •

edited

google-oss-bot commented Nov 16, 2021 •

edited

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

google-oss-bot commented Nov 17, 2021 •

edited

`@firebase/app-check`

`@firebase/firestore`

`bundle`

`firebase`