Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @throws API comment for CRUD methods #5827

Merged
merged 1 commit into from Dec 22, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Dec 21, 2021

Addresses #5818

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Dec 21, 2021

⚠️ No Changeset found

Latest commit: 6b34646

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 21, 2021

Binary Size Report

Affected SDKs

  • firebase

    Type Base (9295bb0) Head (8aeee4c) Diff
    firebase-firestore-lite.js 245 kB 245 kB +76 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 21, 2021

Size Analysis Report

Affected Products

No changes between base commit (9295bb0) and head commit (8aeee4c).

@schmidt-sebastian schmidt-sebastian merged commit c2fff0c into master Dec 22, 2021
20 checks passed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/throws branch Dec 22, 2021
@firebase firebase locked and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants