Add jest exception #5858
Merged
Add jest exception #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsTest Logs |
Size Analysis Report 1This report is too large (1354164 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
packages/firestore/rollup.config.js
Outdated
| return ( | ||
| "(typeof document === 'undefined' ? new (require('url').URL)" + | ||
| "((typeof document === 'undefined' || process.env.JEST_WORKER_ID " + |
There was a problem hiding this comment.
Do we need to check whether process and process.env are defined?
There was a problem hiding this comment.
Yes, that seems important, added.
schmidt-sebastian
approved these changes
Jan 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack to fix for Vercel while not re-breaking for Jest.