Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testIgnoresTargetMappingAfterExistenceFilterMismatch #5880

Merged
merged 1 commit into from Jan 11, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jan 11, 2022

No description provided.

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Jan 11, 2022

⚠️ No Changeset found

Latest commit: eacd437

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Jan 11, 2022

Copy link
Contributor

@dconeybe dconeybe left a comment

Can you just add a description to the PR to explain what the improvement is?

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Jan 11, 2022

@schmidt-sebastian schmidt-sebastian merged commit d0c8bfe into master Jan 11, 2022
20 checks passed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/improvetests branch Jan 11, 2022
@firebase firebase locked and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants