Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Add missing PhoneMultiFactorInfo public interface #5924

Merged
merged 3 commits into from
Jan 25, 2022
Merged

[Auth] Add missing PhoneMultiFactorInfo public interface #5924

merged 3 commits into from
Jan 25, 2022

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jan 24, 2022

Fixes #5922

@sam-gc sam-gc requested a review from allspain as a code owner January 24, 2022 22:41
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 867223b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth/cordova

    TypeBase (2d04af9)Merge (dfa77d6)Diff
    browser180 kB180 kB+28 B (+0.0%)
    module180 kB180 kB+28 B (+0.0%)

  • @firebase/auth/internal

    TypeBase (2d04af9)Merge (dfa77d6)Diff
    browser163 kB163 kB+12 B (+0.0%)
    esm5212 kB212 kB+28 B (+0.0%)
    main179 kB179 kB+28 B (+0.0%)
    module163 kB163 kB+12 B (+0.0%)

  • @firebase/auth/react-native

    TypeBase (2d04af9)Merge (dfa77d6)Diff
    browser163 kB163 kB+28 B (+0.0%)
    module163 kB163 kB+28 B (+0.0%)

  • firebase

    TypeBase (2d04af9)Merge (dfa77d6)Diff
    firebase-auth-cordova.js462 kB462 kB+28 B (+0.0%)
    firebase-auth-react-native.js484 kB484 kB+28 B (+0.0%)
    firebase-auth.js411 kB411 kB+12 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/m3PXasvgOi.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • checkActionCode

      Dependency

      TypeBase (2d04af9)Merge (30fb0e3)Diff
      classes

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

    • getMultiFactorResolver

      Dependency

      TypeBase (2d04af9)Merge (30fb0e3)Diff
      classes

      17 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorResolverImpl
MultiFactorSessionImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserCredentialImpl
UserImpl
UserMetadata

      17 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorResolverImpl
MultiFactorSessionImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserCredentialImpl
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

    • multiFactor

      Dependency

      TypeBase (2d04af9)Merge (30fb0e3)Diff
      classes

      16 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorSessionImpl
MultiFactorUserImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      16 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorSessionImpl
MultiFactorUserImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

    • verifyPasswordResetCode

      Dependency

      TypeBase (2d04af9)Merge (30fb0e3)Diff
      classes

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0cddx91xGs.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • checkActionCode

      Dependency

      TypeBase (2d04af9)Merge (dfa77d6)Diff
      classes

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

    • getMultiFactorResolver

      Dependency

      TypeBase (2d04af9)Merge (dfa77d6)Diff
      classes

      17 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorResolverImpl
MultiFactorSessionImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserCredentialImpl
UserImpl
UserMetadata

      17 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorResolverImpl
MultiFactorSessionImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserCredentialImpl
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

    • multiFactor

      Dependency

      TypeBase (2d04af9)Merge (dfa77d6)Diff
      classes

      16 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorSessionImpl
MultiFactorUserImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      16 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorSessionImpl
MultiFactorUserImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

    • verifyPasswordResetCode

      Dependency

      TypeBase (2d04af9)Merge (dfa77d6)Diff
      classes

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      14 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      + PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BDg5pnkk7f.html

@sam-gc sam-gc merged commit e04b745 into master Jan 25, 2022
@sam-gc sam-gc deleted the sam-gc/phonemultifactorinfo branch January 25, 2022 17:32
@google-oss-bot google-oss-bot mentioned this pull request Jan 26, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@allspain allspain Awaiting requested review from allspain

@avolkovi avolkovi Awaiting requested review from avolkovi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@lisajian lisajian

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing PhoneMultiFactorInfo type in v9
6 participants
@sam-gc @google-oss-bot @hsubox76 @kevinthecheung @lisajian @yuchenshi