Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node-fetch due to security issue #5928

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Update node-fetch due to security issue #5928

merged 4 commits into from
Jan 26, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 25, 2022 •
edited

Update node-fetch due to security issue.

See https://nvd.nist.gov/vuln/detail/CVE-2022-0235

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022 •
edited

Size Report 1

Affected Products

No changes between base commit (e28b0e4) and merge commit (5647af1).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CVpaIPgA3A.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022 •
edited

Size Analysis Report 1

Affected Products

No changes between base commit (e28b0e4) and merge commit (7f2fdf7).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jVQfyoNcYK.html

@AviVahl AviVahl mentioned this pull request Jan 26, 2022
Closed
@hsubox76 hsubox76 changed the title Update node-fetch to 3.2.0 Update node-fetch due to security issue Jan 26, 2022
@hsubox76 hsubox76 mentioned this pull request Jan 26, 2022
Closed
@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2022 •
edited

🦋 Changeset detected

Latest commit: d57807f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/rules-unit-testing Patch
@firebase/storage Patch
firebase Patch
@firebase/storage-compat Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2022 •
edited

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@hsubox76 hsubox76 assigned allspain and unassigned allspain Jan 26, 2022
@hsubox76 hsubox76 merged commit d612d6f into master Jan 26, 2022
@hsubox76 hsubox76 deleted the ch-node-fetch branch January 26, 2022 21:04
@google-oss-bot google-oss-bot mentioned this pull request Jan 26, 2022
Merged
@sam-gc sam-gc mentioned this pull request Jan 27, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@allspain allspain allspain approved these changes

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 is a code owner

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@allspain allspain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hsubox76 @google-oss-bot @allspain @sam-gc