Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag some internal auth types with @internal tag #6248

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 6, 2022

Somehow #6151 caused api-extractor to write these types to the public d.ts when it hadn't previously. Explicitly tagging them as @internal.

Tested: not getting squiggly lines anymore in auth-public.d.ts in VSCode with TypeScript linting turned on.

Fixes #6246

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2022

🦋 Changeset detected

Latest commit: c98b4ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@hsubox76 hsubox76 requested a review from egilmorez as a code owner May 6, 2022 22:41
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2022

@hsubox76 hsubox76 merged commit 07cf0f1 into master May 9, 2022
@hsubox76 hsubox76 deleted the ch-auth-types branch May 9, 2022 16:37
@google-oss-bot google-oss-bot mentioned this pull request May 9, 2022
@google-oss-bot google-oss-bot mentioned this pull request May 24, 2022
@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect auth typing in 9.8.0: Cannot find name 'PhoneOrOauthTokenResponse
3 participants