Support logical termination for grpc connection #6324

cherylEnkidu · 2022-06-02T17:17:27Z

No description provided.

changeset-bot · 2022-06-02T17:17:30Z

⚠️ No Changeset found

Latest commit: 6589bd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-06-02T17:36:09Z

Size Report ¹

Affected Products

@firebase/analytics
Type Base (0197076) Merge (7449eb8) Diff
browser 18.9 kB 19.0 kB +54 B (+0.3%)
esm5 23.5 kB 23.6 kB +54 B (+0.2%)
main 24.6 kB 24.7 kB +54 B (+0.2%)
module 18.9 kB 19.0 kB +54 B (+0.3%)

`@firebase/auth`

Type	Base (`0197076`)	Merge (`7449eb8`)	Diff
browser	155 kB	155 kB	+241 B (+0.2%)
cordova	183 kB	183 kB	+237 B (+0.1%)
esm5	202 kB	203 kB	+237 B (+0.1%)
main	148 kB	148 kB	+237 B (+0.2%)
module	155 kB	155 kB	+241 B (+0.2%)
react-native	168 kB	168 kB	+237 B (+0.1%)

@firebase/auth-compat
Type Base (0197076) Merge (7449eb8) Diff
browser 20.2 kB 20.2 kB +40 B (+0.2%)
esm5 27.0 kB 27.1 kB +40 B (+0.1%)
main 29.6 kB 29.6 kB +40 B (+0.1%)
module 20.2 kB 20.2 kB +40 B (+0.2%)
@firebase/auth/cordova
Type Base (0197076) Merge (7449eb8) Diff
browser 183 kB 183 kB +237 B (+0.1%)
module 183 kB 183 kB +237 B (+0.1%)
@firebase/auth/internal
Type Base (0197076) Merge (7449eb8) Diff
browser 166 kB 166 kB +241 B (+0.1%)
esm5 216 kB 216 kB +237 B (+0.1%)
main 183 kB 183 kB +237 B (+0.1%)
module 166 kB 166 kB +241 B (+0.1%)
@firebase/auth/react-native
Type Base (0197076) Merge (7449eb8) Diff
browser 168 kB 168 kB +237 B (+0.1%)
module 168 kB 168 kB +237 B (+0.1%)

`@firebase/firestore`

Type	Base (`0197076`)	Merge (`7449eb8`)	Diff
browser	257 kB	262 kB	+4.82 kB (+1.9%)
esm5	319 kB	325 kB	+5.89 kB (+1.8%)
main	515 kB	522 kB	+6.25 kB (+1.2%)
module	257 kB	262 kB	+4.82 kB (+1.9%)
react-native	257 kB	262 kB	+4.82 kB (+1.9%)

`@firebase/firestore-lite`

Type	Base (`0197076`)	Merge (`7449eb8`)	Diff
browser	80.5 kB	80.5 kB	+17 B (+0.0%)
esm5	96.2 kB	96.2 kB	+17 B (+0.0%)
main	135 kB	135 kB	+79 B (+0.1%)
module	80.5 kB	80.5 kB	+17 B (+0.0%)
react-native	80.7 kB	80.7 kB	+17 B (+0.0%)

@firebase/installations
Type Base (0197076) Merge (7449eb8) Diff
browser 17.8 kB 17.8 kB +1 B (+0.0%)
esm5 22.9 kB 22.9 kB +1 B (+0.0%)
main 23.8 kB 23.8 kB +1 B (+0.0%)
module 17.8 kB 17.8 kB +1 B (+0.0%)
@firebase/installations-compat
Type Base (0197076) Merge (7449eb8) Diff
browser 944 B 945 B +1 B (+0.1%)
esm5 1.16 kB 1.16 kB +1 B (+0.1%)
main 1.48 kB 1.49 kB +1 B (+0.1%)
module 944 B 945 B +1 B (+0.1%)
@firebase/messaging
Type Base (0197076) Merge (7449eb8) Diff
browser 20.8 kB 21.2 kB +331 B (+1.6%)
esm5 26.2 kB 26.5 kB +331 B (+1.3%)
main 26.9 kB 27.2 kB +331 B (+1.2%)
module 20.8 kB 21.2 kB +331 B (+1.6%)
@firebase/messaging-sw
Type Base (0197076) Merge (7449eb8) Diff
main 29.6 kB 29.9 kB +289 B (+1.0%)
module 22.9 kB 23.2 kB +289 B (+1.3%)
@firebase/performance
Type Base (0197076) Merge (7449eb8) Diff
browser 29.1 kB 29.1 kB +1 B (+0.0%)
esm5 30.8 kB 30.8 kB +1 B (+0.0%)
main 31.2 kB 31.2 kB +1 B (+0.0%)
module 29.1 kB 29.1 kB +1 B (+0.0%)
@firebase/performance-compat
Type Base (0197076) Merge (7449eb8) Diff
browser 1.10 kB 1.10 kB +1 B (+0.1%)
esm5 1.37 kB 1.38 kB +1 B (+0.1%)
main 1.69 kB 1.69 kB +1 B (+0.1%)
module 1.10 kB 1.10 kB +1 B (+0.1%)
@firebase/remote-config-compat
Type Base (0197076) Merge (7449eb8) Diff
browser 1.85 kB 1.85 kB +1 B (+0.1%)
esm5 2.76 kB 2.76 kB +1 B (+0.0%)
main 3.09 kB 3.09 kB +1 B (+0.0%)
module 1.85 kB 1.85 kB +1 B (+0.1%)

`bundle`

22 size changes

Type	Base (`0197076`)	Merge (`7449eb8`)	Diff
analytics (logEvent)	41.6 kB	41.6 kB	+51 B (+0.1%)
auth (Anonymous)	66.1 kB	66.3 kB	+167 B (+0.3%)
auth (EmailAndPassword)	70.2 kB	70.4 kB	+167 B (+0.2%)
auth (GoogleFBTwitterGitHubPopup)	90.1 kB	90.2 kB	+177 B (+0.2%)
auth (GooglePopup)	89.8 kB	90.0 kB	+177 B (+0.2%)
auth (GoogleRedirect)	90.0 kB	90.2 kB	+177 B (+0.2%)
auth (Phone)	76.2 kB	76.4 kB	+167 B (+0.2%)
firestore (Persistence)	269 kB	273 kB	+4.74 kB (+1.8%)
firestore (Query Cursors)	208 kB	210 kB	+2.29 kB (+1.1%)
firestore (Query)	209 kB	211 kB	+2.29 kB (+1.1%)
firestore (Read data once)	197 kB	200 kB	+2.29 kB (+1.2%)
firestore (Realtime updates)	200 kB	202 kB	+2.29 kB (+1.1%)
firestore (Transaction)	181 kB	184 kB	+2.18 kB (+1.2%)
firestore (Write data)	181 kB	183 kB	+2.41 kB (+1.3%)
firestore-lite (Query Cursors)	208 kB	210 kB	+2.29 kB (+1.1%)
firestore-lite (Query)	208 kB	210 kB	+2.29 kB (+1.1%)
firestore-lite (Read data once)	197 kB	200 kB	+2.29 kB (+1.2%)
firestore-lite (Transaction)	181 kB	184 kB	+2.18 kB (+1.2%)
firestore-lite (Write data)	181 kB	183 kB	+2.41 kB (+1.3%)
messaging (send + receive)	44.7 kB	45.0 kB	+266 B (+0.6%)
performance (trace)	49.6 kB	49.6 kB	+2 B (+0.0%)
remote-config (getAndFetch)	44.2 kB	44.2 kB	+1 B (+0.0%)

`firebase`

23 size changes

Type	Base (`0197076`)	Merge (`7449eb8`)	Diff
firebase-analytics-compat.js	25.6 kB	25.6 kB	+42 B (+0.2%)
firebase-analytics.js	111 kB	111 kB	+93 B (+0.1%)
firebase-app-check.js	90.2 kB	90.2 kB	+20 B (+0.0%)
firebase-app.js	87.6 kB	87.6 kB	+20 B (+0.0%)
firebase-auth-compat.js	125 kB	125 kB	+200 B (+0.2%)
firebase-auth-cordova.js	472 kB	472 kB	+371 B (+0.1%)
firebase-auth-react-native.js	495 kB	495 kB	+391 B (+0.1%)
firebase-auth.js	417 kB	418 kB	+395 B (+0.1%)
firebase-compat.js	788 kB	793 kB	+5.44 kB (+0.7%)
firebase-firestore-compat.js	309 kB	314 kB	+4.76 kB (+1.5%)
firebase-firestore-lite.js	837 kB	845 kB	+8.01 kB (+1.0%)
firebase-firestore.js	837 kB	845 kB	+8.01 kB (+1.0%)
firebase-functions.js	32.0 kB	32.1 kB	+20 B (+0.1%)
firebase-messaging-compat.js	37.5 kB	38.0 kB	+449 B (+1.2%)
firebase-messaging-sw.js	107 kB	107 kB	+488 B (+0.5%)
firebase-messaging.js	105 kB	106 kB	+548 B (+0.5%)
firebase-performance-compat.js	30.7 kB	30.7 kB	+3 B (+0.0%)
firebase-performance-standalone-compat.es2017.js	87.5 kB	87.5 kB	+4 B (+0.0%)
firebase-performance-standalone-compat.js	65.3 kB	65.3 kB	+3 B (+0.0%)
firebase-performance.js	123 kB	123 kB	+22 B (+0.0%)
firebase-remote-config-compat.js	27.3 kB	27.3 kB	+2 B (+0.0%)
firebase-remote-config.js	113 kB	113 kB	+21 B (+0.0%)
firebase-storage.js	146 kB	146 kB	+20 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ulycA4IqPJ.html

google-oss-bot · 2022-06-02T18:07:43Z

Size Analysis Report ¹

This report is too large (818,541 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/4jYr2cyPyi.html

packages/firestore/src/platform/node/grpc_connection.ts

Support logical termination for grpc connection

dbb7f06

cherylEnkidu force-pushed the cheryllin/BatchGetDocuments branch from 8c0ccd6 to dbb7f06 Compare June 2, 2022 22:12

cherylEnkidu requested a review from wu-hui June 3, 2022 17:07

cherylEnkidu assigned wu-hui Jun 3, 2022

wu-hui reviewed Jun 10, 2022

View reviewed changes

packages/firestore/src/platform/node/grpc_connection.ts Outdated Show resolved Hide resolved

wu-hui assigned cherylEnkidu and unassigned wu-hui Jun 10, 2022

Address Feedback

6589bd6

cherylEnkidu assigned wu-hui and unassigned cherylEnkidu Jun 16, 2022

wu-hui approved these changes Jun 16, 2022

View reviewed changes

wu-hui assigned cherylEnkidu and unassigned wu-hui Jun 16, 2022

cherylEnkidu merged commit 421fc3b into master Jun 16, 2022

cherylEnkidu deleted the cheryllin/BatchGetDocuments branch June 16, 2022 20:35

firebase locked and limited conversation to collaborators Jul 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support logical termination for grpc connection #6324

Support logical termination for grpc connection #6324

cherylEnkidu commented Jun 2, 2022

changeset-bot bot commented Jun 2, 2022 •

edited

google-oss-bot commented Jun 2, 2022 •

edited

`@firebase/analytics`

`@firebase/auth`

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/installations`

`@firebase/installations-compat`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/performance`

`@firebase/performance-compat`

`@firebase/remote-config-compat`

`bundle`

`firebase`

google-oss-bot commented Jun 2, 2022 •

edited

Support logical termination for grpc connection #6324

Support logical termination for grpc connection #6324

Conversation

cherylEnkidu commented Jun 2, 2022

changeset-bot bot commented Jun 2, 2022 • edited

⚠️ No Changeset found

google-oss-bot commented Jun 2, 2022 • edited

Size Report 1

Affected Products

@firebase/analytics

@firebase/auth

@firebase/auth-compat

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

@firebase/firestore

@firebase/firestore-lite

@firebase/installations

@firebase/installations-compat

@firebase/messaging

@firebase/messaging-sw

@firebase/performance

@firebase/performance-compat

@firebase/remote-config-compat

bundle

firebase

Test Logs

google-oss-bot commented Jun 2, 2022 • edited

Size Analysis Report 1

Test Logs

changeset-bot bot commented Jun 2, 2022 •

edited

google-oss-bot commented Jun 2, 2022 •

edited

Size Report ¹

`@firebase/analytics`

`@firebase/auth`

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/installations`

`@firebase/installations-compat`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/performance`

`@firebase/performance-compat`

`@firebase/remote-config-compat`

`bundle`

`firebase`

google-oss-bot commented Jun 2, 2022 •

edited

Size Analysis Report ¹