Add function setDefaultEventParameters() to set data that will be logged on every analytics SDK event #6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b016fbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
dwyfrequency
changed the title
hsubox76
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Looks good, just a few comments. Have @egilmorez review reference doc comment text (I tagged him in a comment at the exact spot).
packages/analytics/src/api.ts
Outdated
| @@ -224,6 +225,23 @@ export function setAnalyticsCollectionEnabled( | |||
| enabled | |||
| ).catch(e => logger.error(e)); | |||
| } | |||
|
|
|||
| /** | |||
| * Adds data that will be set on every event logged from the SDK, including automatic one. | |||
There was a problem hiding this comment.
@egilmorez Can you review the text here? This comment here should be the only text that will end up in the reference docs.
From me:
- one => ones
- In "gtag's set command" the "set" should be in quotes or backticks, I think quotes because it's a string not a var
hsubox76
reviewed
Jun 22, 2022
hsubox76
reviewed
Jun 22, 2022
hsubox76
approved these changes
Jun 23, 2022
egilmorez
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to set data that will be set on every event logged from the SDK, including automatic one.