Fixed faulty transaction bug #6508

maneesht · 2022-08-04T22:18:43Z

Fixed issue where transaction callbacks were given inaccurate data when concurrent writes occur.

Bug first introduced here.

changeset-bot · 2022-08-04T22:18:45Z

🦋 Changeset detected

Latest commit: 2308022

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/database-compat	Patch
@firebase/database	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-08-04T22:39:59Z

Size Report ¹

Affected Products

@firebase/database
Type Base (2b2079d) Merge (7efa28d) Diff
browser 248 kB 248 kB -5 B (-0.0%)
esm5 276 kB 276 kB -5 B (-0.0%)
main 281 kB 281 kB -5 B (-0.0%)
module 248 kB 248 kB -5 B (-0.0%)
@firebase/database-compat/standalone
Type Base (2b2079d) Merge (7efa28d) Diff
main 370 kB 370 kB -5 B (-0.0%)

`bundle`

Type	Base (`2b2079d`)	Merge (`7efa28d`)	Diff
database (Append to a list of data)	145 kB	145 kB	-5 B (-0.0%)
database (Filtering data)	144 kB	144 kB	-5 B (-0.0%)
database (Listen for child events)	160 kB	160 kB	-5 B (-0.0%)
database (Listen for value events + Detach listeners)	160 kB	160 kB	-5 B (-0.0%)
database (Listen for value events)	160 kB	160 kB	-5 B (-0.0%)
database (Read data once)	159 kB	159 kB	-5 B (-0.0%)
database (Save data as transactions)	162 kB	162 kB	-5 B (-0.0%)
database (Sort data)	145 kB	145 kB	-5 B (-0.0%)
database (Write data)	144 kB	144 kB	-5 B (-0.0%)

firebase
Type Base (2b2079d) Merge (7efa28d) Diff
firebase-compat.js 794 kB 794 kB -2 B (-0.0%)
firebase-database-compat.js 166 kB 166 kB -2 B (-0.0%)
firebase-database.js 153 kB 153 kB -2 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ODZ6h5lzia.html

google-oss-bot · 2022-08-04T22:54:54Z

Size Analysis Report ¹

Affected Products

@firebase/database
- DataSnapshot
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -5 B (-0.0%)
- Database
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 136 kB 136 kB -5 B (-0.0%)
- OnDisconnect
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 119 kB 119 kB -5 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -5 B (-0.0%)
- QueryConstraint
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- TransactionResult
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- _QueryImpl
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 136 kB 136 kB -5 B (-0.0%)
- _QueryParams
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 136 kB 136 kB -5 B (-0.0%)
- _ReferenceImpl
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 136 kB 136 kB -5 B (-0.0%)
- _TEST_ACCESS_forceRestClient
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- _TEST_ACCESS_hijackHash
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- _repoManagerDatabaseFromApp
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- _setSDKVersion
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 136 kB 136 kB -5 B (-0.0%)
- _validatePathString
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- _validateWritablePath
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- child
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- connectDatabaseEmulator
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -5 B (-0.0%)
- enableLogging
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- endAt
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 118 kB 118 kB -5 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -5 B (-0.0%)
- endBefore
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 118 kB 118 kB -5 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -5 B (-0.0%)
- equalTo
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 119 kB 119 kB -5 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -5 B (-0.0%)
- forceLongPolling
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- forceWebSockets
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- get
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 132 kB 132 kB -5 B (-0.0%)
  size-with-ext-deps 153 kB 153 kB -5 B (-0.0%)
- getDatabase
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- goOffline
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- goOnline
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- increment
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- limitToFirst
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- limitToLast
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- off
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 124 kB 124 kB -5 B (-0.0%)
  size-with-ext-deps 145 kB 145 kB -5 B (-0.0%)
- onChildAdded
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 132 kB 132 kB -5 B (-0.0%)
  size-with-ext-deps 153 kB 153 kB -5 B (-0.0%)
- onChildChanged
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 132 kB 132 kB -5 B (-0.0%)
  size-with-ext-deps 153 kB 153 kB -5 B (-0.0%)
- onChildMoved
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 132 kB 132 kB -5 B (-0.0%)
  size-with-ext-deps 153 kB 153 kB -5 B (-0.0%)
- onChildRemoved
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 132 kB 132 kB -5 B (-0.0%)
  size-with-ext-deps 153 kB 153 kB -5 B (-0.0%)
- onDisconnect
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 119 kB 119 kB -5 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -5 B (-0.0%)
- onValue
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 132 kB 132 kB -5 B (-0.0%)
  size-with-ext-deps 153 kB 153 kB -5 B (-0.0%)
- orderByChild
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 118 kB 118 kB -5 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -5 B (-0.0%)
- orderByKey
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 117 kB 117 kB -5 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -5 B (-0.0%)
- orderByPriority
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 117 kB 117 kB -5 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -5 B (-0.0%)
- orderByValue
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 117 kB 117 kB -5 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -5 B (-0.0%)
- push
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 117 kB 117 kB -5 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -5 B (-0.0%)
- query
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- ref
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- refFromURL
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- remove
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- runTransaction
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 134 kB 134 kB -5 B (-0.0%)
  size-with-ext-deps 155 kB 155 kB -5 B (-0.0%)
- serverTimestamp
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 115 kB 115 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- set
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 116 kB 116 kB -5 B (-0.0%)
  size-with-ext-deps 137 kB 137 kB -5 B (-0.0%)
- setPriority
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 117 kB 117 kB -5 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -5 B (-0.0%)
- setWithPriority
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 117 kB 117 kB -5 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -5 B (-0.0%)
- startAfter
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 118 kB 118 kB -5 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -5 B (-0.0%)
- startAt
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 118 kB 118 kB -5 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -5 B (-0.0%)
- update
  Size
  Type Base (2b2079d) Merge (7efa28d) Diff
  size 118 kB 118 kB -5 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -5 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/PBFDaz2L6u.html

github-actions · 2022-08-10T21:17:26Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

…tions

…e/firebase-js-sdk into mtewani/fix-transactions

scripts/emulator-testing/emulators/database-emulator.ts

jmwski

Could you drop a reference to when this broken behavior was introduced in the PR description?

README.md

.changeset/warm-pillows-know.md

Fixed faulty transaction bug

47fb468

maneesht added 2 commits August 7, 2022 15:04

WIP

7c10309

Included repro test

452abc5

maneesht and others added 4 commits August 10, 2022 14:22

Added todo

07fc465

WIP

52669cd

Included index in our tests

fbe94aa

Create warm-pillows-know.md

9e09bd2

maneesht marked this pull request as ready for review August 12, 2022 22:30

maneesht requested review from egilmorez, avolkovi, sam-gc, yuchenshi, jsdt, dwyfrequency and hsubox76 as code owners August 12, 2022 22:30

maneesht added 7 commits August 12, 2022 15:31

Merge remote-tracking branch 'origin/master' into mtewani/fix-transac…

169b5cc

…tions

Merge branch 'mtewani/fix-transactions' of https://github.com/firebas…

57966f2

…e/firebase-js-sdk into mtewani/fix-transactions

Removed unnecessary changes

76dfbf6

Undid change

e1b3014

Removed console log

8e67f2d

Replaced count check

858d6a1

Updated formatting

e13f2cd

maneesht assigned jmwski Aug 12, 2022

maneesht requested a review from jmwski August 12, 2022 22:45

maneesht added 2 commits August 12, 2022 15:47

Removed unnecessary import

88ca7d6

Removed only and added comment

5b1c04b

jmwski reviewed Aug 15, 2022

View reviewed changes

scripts/emulator-testing/emulators/database-emulator.ts Outdated Show resolved Hide resolved

jmwski reviewed Aug 15, 2022

View reviewed changes

Removed changes to database.rules.json

8611f5a

jmwski assigned maneesht and unassigned jmwski Aug 15, 2022

maneesht added 3 commits August 15, 2022 10:05

Fixed formatting

89dfd2a

Updated database emulator script and rules

f85a1be

Updated formatting and README

f645eba

maneesht assigned jmwski and unassigned maneesht Aug 15, 2022

jmwski approved these changes Aug 15, 2022

View reviewed changes

maneesht assigned hsubox76 Aug 15, 2022

Removed extra affected package

13b9247

hsubox76 approved these changes Aug 15, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

.changeset/warm-pillows-know.md Outdated Show resolved Hide resolved

Addressed comments

2308022

maneesht merged commit fcd4b8a into master Aug 15, 2022

maneesht deleted the mtewani/fix-transactions branch August 15, 2022 22:16

google-oss-bot mentioned this pull request Aug 16, 2022

Version Packages #6539

Merged

firebase locked and limited conversation to collaborators Sep 15, 2022

Fixed faulty transaction bug #6508

Fixed faulty transaction bug #6508

Conversation

maneesht commented Aug 4, 2022 • edited Loading

changeset-bot bot commented Aug 4, 2022 • edited Loading

🦋 Changeset detected

google-oss-bot commented Aug 4, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/database

@firebase/database-compat/standalone

bundle

firebase

Test Logs

google-oss-bot commented Aug 4, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/database

DataSnapshot

Database

OnDisconnect

QueryConstraint

TransactionResult

_QueryImpl

_QueryParams

_ReferenceImpl

_TEST_ACCESS_forceRestClient

_TEST_ACCESS_hijackHash

_repoManagerDatabaseFromApp

_setSDKVersion

_validatePathString

_validateWritablePath

child

connectDatabaseEmulator

enableLogging

endAt

endBefore

equalTo

forceLongPolling

forceWebSockets

get

getDatabase

goOffline

goOnline

increment

limitToFirst

limitToLast

off

onChildAdded

onChildChanged

onChildMoved

onChildRemoved

onDisconnect

onValue

orderByChild

orderByKey

orderByPriority

orderByValue

push

query

ref

refFromURL

remove

runTransaction

serverTimestamp

set

setPriority

setWithPriority

startAfter

startAt

update

Test Logs

github-actions bot commented Aug 10, 2022 • edited Loading

Changeset File Check ✅

jmwski left a comment • edited Loading

Choose a reason for hiding this comment

maneesht commented Aug 4, 2022 •

edited

Loading

changeset-bot bot commented Aug 4, 2022 •

edited

Loading

google-oss-bot commented Aug 4, 2022 •

edited

Loading

Size Report ¹

`@firebase/database`

`@firebase/database-compat/standalone`

`bundle`

`firebase`

google-oss-bot commented Aug 4, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/database`

`DataSnapshot`

`Database`

`OnDisconnect`

`QueryConstraint`

`TransactionResult`

`_QueryImpl`

`_QueryParams`

`_ReferenceImpl`

`_TEST_ACCESS_forceRestClient`

`_TEST_ACCESS_hijackHash`

`_repoManagerDatabaseFromApp`

`_setSDKVersion`

`_validatePathString`

`_validateWritablePath`

`child`

`connectDatabaseEmulator`

`enableLogging`

`endAt`

`endBefore`

`equalTo`

`forceLongPolling`

`forceWebSockets`

`get`

`getDatabase`

`goOffline`

`goOnline`

`increment`

`limitToFirst`

`limitToLast`

`off`

`onChildAdded`

`onChildChanged`

`onChildMoved`

`onChildRemoved`

`onDisconnect`

`onValue`

`orderByChild`

`orderByKey`

`orderByPriority`

`orderByValue`

`push`

`query`

`ref`

`refFromURL`

`remove`

`runTransaction`

`serverTimestamp`

`set`

`setPriority`

`setWithPriority`

`startAfter`

`startAt`

`update`

github-actions bot commented Aug 10, 2022 •

edited

Loading

jmwski left a comment •

edited

Loading