Remove all references to @firebase/polyfill from repo
#6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 43f99bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsTest Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (9f1e3c6) and merge commit (bc95d81).Test Logs |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously provided a
@firebase/polyfilllibrary for polyfills needed to get the SDK working in older browsers. We stopped providing this upon the v9 release, as official policy on v9 release was to ask users to provide their own polyfills if they need them. It's still included as a dependency inpackages/firebase/package.jsonand it's imported in the compat CDN builds. I'm not sure if that was intentional, but since we don't maintain the package any more (it's been deleted from the repo) and can't update it, I don't think we should depend on it.Removed import in compat CDN and dependency from firebase/package.json. Also updated the version of
firebaseine2e/even though it doesn't matter (it's reinstalled every time the e2e workflow runs), just so@firebase/polyfillgets removed from itsyarn.lockas well.Fixes #6503