Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): fix redirect invalid caching issue #67

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

jshcrowthe
Copy link
Contributor

Import latest auth build, fixed issue where offline network status was getting cached and not correctly cleared.

Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an additional change in this: Modified custom URL scheme redirect for Cordova to be case insensitive when checking that the incoming link matches the app's bundle ID retrieved via BuildInfo.packageName.

@bojeil-google
Copy link
Contributor

The latter issue was reported here: firebase/firebaseui-web#172

@jshcrowthe
Copy link
Contributor Author

Awesome. Then let's get this merged and a release cut this week so we can update pins.

@jshcrowthe jshcrowthe merged commit 5f2ca5a into master Jun 19, 2017
@jshcrowthe jshcrowthe deleted the auth-import-6-19 branch June 19, 2017 17:54
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants