Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move default condition to last #7006

Closed
wants to merge 1 commit into from
Closed

move default condition to last #7006

wants to merge 1 commit into from

Conversation

joshdchang
Copy link

@joshdchang joshdchang commented Feb 3, 2023

Discussion

It seems like #6981 has introduced a bug that prevents webpack projects from compiling by mis-ordering the conditions in many of the package.json files. This can be fixed by simply reordering the default condition to make it last in any affected files.

See #7002 and #7005.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

⚠️ No Changeset found

Latest commit: 4ddef38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla
Copy link

google-cla bot commented Feb 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hsubox76
Copy link
Contributor

hsubox76 commented Feb 3, 2023

Thanks for the PR and bringing up the issue, you're missing firestore-compat and need to add a changeset (run yarn changeset). This seems pretty urgent so I will work on a separate PR in parallel in case you're not able to respond immediately.

@hsubox76 hsubox76 mentioned this pull request Feb 3, 2023
@joshdchang joshdchang closed this by deleting the head repository Feb 3, 2023
@firebase firebase locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants