Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builds to E2E workflow #7013

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Add builds to E2E workflow #7013

merged 1 commit into from
Feb 9, 2023

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 6, 2023

Add steps in E2E smoke test just to see if the app will build with a pretty standard webpack config. This would have caught #7005 . The E2E unit tests are run with karma-typescript and don't use webpack at all so they didn't catch this.

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023

⚠️ No Changeset found

Latest commit: f01c9c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 marked this pull request as ready for review February 7, 2023 17:43
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 9874614 into master Feb 9, 2023
@hsubox76 hsubox76 deleted the ch-e2e-conditions branch February 9, 2023 21:00
hsubox76 added a commit that referenced this pull request Feb 9, 2023
NhienLam pushed a commit that referenced this pull request Feb 14, 2023
@firebase firebase locked and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants