Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing command to install packages #7183

Merged
merged 1 commit into from
Mar 31, 2023
Merged

added missing command to install packages #7183

merged 1 commit into from
Mar 31, 2023

Conversation

bhparijat
Copy link
Contributor

Added a command in readme to install packages after removing npm modules.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

⚠️ No Changeset found

Latest commit: f65f275

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

prameshj
prameshj reviewed Mar 31, 2023
View reviewed changes
packages/auth/demo/README.md
@@ -57,6 +57,7 @@ You can optionally clear the cache and rebuild using:
```bash
cd auth/demo
rm -rf node_modules yarn.lock
yarn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually do yarn build:deps && yarn install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean yarn install && yarn build:deps ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done in the other order, but makes sense to install deps and then build like you have in this PR.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (965396d) and merge commit (d7e0e69).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5DpA8Pw1GG.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (965396d) and merge commit (d7e0e69).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kePaw3r0GV.html

@bhparijat bhparijat merged commit 48a2096 into master Mar 31, 2023
@bhparijat bhparijat deleted the fix-readme-demoapp branch March 31, 2023 20:45
@firebase firebase locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prameshj prameshj prameshj approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@renkelvin renkelvin Awaiting requested review from renkelvin

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhparijat @google-oss-bot @prameshj