Allow http redirect for localhost testing #7783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhparijat
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc and
a team
as code owners
🦋 Changeset detectedLatest commit: 0c05811 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bhparijat
force-pushed
the
baseUrl-fix
branch
2 times, most recently
from
66da067
to
3349186
Compare
Size Report 1Affected Products
Test Logs |
egilmorez
approved these changes
Nov 30, 2023
bhparijat
force-pushed
the
baseUrl-fix
branch
from
3349186
to
c9b775c
Compare
Size Analysis Report 1Affected Products
Test Logs |
prameshj
approved these changes
Dec 13, 2023
prameshj
reviewed
Dec 13, 2023
| @@ -129,8 +129,11 @@ export async function _getRedirectUrl( | |||
|
|
|||
| function getHandlerBase({ config }: AuthInternal): string { | |||
| if (!config.emulator) { | |||
| return `https://${config.authDomain}/${WIDGET_PATH}`; | |||
There was a problem hiding this comment.
This will now hardcode http:// for the localhost authDomain. It is possible that this doesn't work for some folks who are setting up TLS on localhost. But i think it is worth merging this and seeing what the feedback is.
Also adding @renkelvin to take a look.
There was a problem hiding this comment.
Good point. I think the fix Parijat just made should fix that.
bhparijat
force-pushed
the
baseUrl-fix
branch
from
c9b775c
to
e58e683
Compare
renkelvin
approved these changes
Dec 13, 2023
|
+1 makes development lot easier pls merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for fixing github issue #7342 to allow http redirect for localhost authdomain.
Tested using demo app that on redirect url uses http instead of https.