Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update injectRecaptchaFields to inject recaptcha enterprise fields into phone API requests #7786

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Update injectRecaptchaFields to inject recaptcha enterprise fields into phone API requests #7786

merged 4 commits into from
Nov 17, 2023

Conversation

NhienLam
Copy link
Contributor

Discussion

This is the pre-req for reCAPTCHA Enterprise and phone auth integration support.

  • Add Phone provider and action names
  • Add reCAPTCHA Enterprise fields to phone API requests
  • Update injectRecaptchaFields to inject recaptcha enterprise fields into phone API requests

Testing

Tested the following flows with the demo app:

  • Phone Auth
  • SMS MFA
  • Email auth with reCAPTCHA Enterprise

@NhienLam NhienLam requested review from lisajian, sam-gc and a team as code owners November 15, 2023 17:56
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2023 •
edited

⚠️ No Changeset found

Latest commit: 3d70b23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NhienLam NhienLam removed request for a team, sam-gc and lisajian November 15, 2023 17:57
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 15, 2023 •
edited

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (bebecda)Merge (4dc4081)Diff
    browser177 kB177 kB+898 B (+0.5%)
    cordova205 kB206 kB+1.01 kB (+0.5%)
    esm5230 kB231 kB+1.01 kB (+0.4%)
    main174 kB175 kB+1.01 kB (+0.6%)
    module177 kB177 kB+898 B (+0.5%)
    react-native194 kB195 kB+1.01 kB (+0.5%)

  • @firebase/auth/cordova

    TypeBase (bebecda)Merge (4dc4081)Diff
    browser205 kB206 kB+1.01 kB (+0.5%)
    module205 kB206 kB+1.01 kB (+0.5%)

  • @firebase/auth/internal

    TypeBase (bebecda)Merge (4dc4081)Diff
    browser187 kB188 kB+898 B (+0.5%)
    esm5244 kB245 kB+1.01 kB (+0.4%)
    main210 kB211 kB+1.01 kB (+0.5%)
    module187 kB188 kB+898 B (+0.5%)

  • bundle

    TypeBase (bebecda)Merge (4dc4081)Diff
    auth (EmailAndPassword)81.4 kB82.1 kB+692 B (+0.9%)

  • firebase

    TypeBase (bebecda)Merge (4dc4081)Diff
    firebase-auth-compat.js136 kB137 kB+665 B (+0.5%)
    firebase-auth-cordova.js174 kB175 kB+683 B (+0.4%)
    firebase-auth.js147 kB147 kB+671 B (+0.5%)
    firebase-compat.js778 kB779 kB+665 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BTViRgvkJO.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 15, 2023 •
edited

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • EmailAuthCredential

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size42.9 kB43.6 kB+692 B (+1.6%)
      size-with-ext-deps63.8 kB64.5 kB+692 B (+1.1%)

    • EmailAuthProvider

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size44.4 kB45.1 kB+692 B (+1.6%)
      size-with-ext-deps65.5 kB66.2 kB+692 B (+1.1%)

    • createUserWithEmailAndPassword

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size42.1 kB42.8 kB+692 B (+1.6%)
      size-with-ext-deps63.0 kB63.6 kB+692 B (+1.1%)

    • initializeRecaptchaConfig

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size40.3 kB40.4 kB+100 B (+0.2%)
      size-with-ext-deps61.2 kB61.3 kB+100 B (+0.2%)

    • sendPasswordResetEmail

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size41.7 kB42.4 kB+692 B (+1.7%)
      size-with-ext-deps62.6 kB63.2 kB+692 B (+1.1%)

    • sendSignInLinkToEmail

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size41.7 kB42.4 kB+692 B (+1.7%)
      size-with-ext-deps62.6 kB63.3 kB+692 B (+1.1%)

    • signInWithEmailAndPassword

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size46.0 kB46.7 kB+692 B (+1.5%)
      size-with-ext-deps67.2 kB67.9 kB+692 B (+1.0%)

    • signInWithEmailLink

      Size

      TypeBase (bebecda)Merge (4dc4081)Diff
      size46.0 kB46.7 kB+692 B (+1.5%)
      size-with-ext-deps67.2 kB67.9 kB+692 B (+1.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/V3RQpis4sA.html

@NhienLam NhienLam merged commit 3bfd025 into rce-phone Nov 17, 2023
37 of 38 checks passed
@NhienLam NhienLam deleted the nhienlam-rce-phone branch November 17, 2023 06:26
NhienLam added a commit that referenced this pull request Nov 23, 2023
@NhienLam
Update injectRecaptchaFields to inject recaptcha enterprise fields in…
1a8f61d 
…to phone API requests (#7786)

* Update injectRecaptchaFields to inject recaptcha fields into phone API requests

* Fix lint

* Rename captchaResp and fakeToken params

* Format
NhienLam added a commit that referenced this pull request Nov 23, 2023
@NhienLam
Update injectRecaptchaFields to inject recaptcha enterprise fields in…
32396d9 
…to phone API requests (#7786)

* Update injectRecaptchaFields to inject recaptcha fields into phone API requests

* Fix lint

* Rename captchaResp and fakeToken params

* Format
@firebase firebase locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

@prameshj prameshj Awaiting requested review from prameshj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NhienLam @google-oss-bot @renkelvin