Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Firestore CSI tree-shaking alternate implementation #7920

Closed
wants to merge 32 commits into from

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 4, 2024

DO NOT MERGE - this PR only exists for the size report. It will eventually be closed and discarded.

@dconeybe dconeybe self-assigned this Jan 4, 2024
Copy link

changeset-bot bot commented Jan 4, 2024

⚠️ No Changeset found

Latest commit: 57b5bcb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 4, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (7f78362)Merge (3c7cc8f)Diff
    browser375 kB377 kB+2.13 kB (+0.6%)
    esm5360 kB362 kB+1.55 kB (+0.4%)
    main577 kB580 kB+3.22 kB (+0.6%)
    module375 kB377 kB+2.13 kB (+0.6%)
    react-native375 kB377 kB+2.13 kB (+0.6%)
  • bundle

    TypeBase (7f78362)Merge (3c7cc8f)Diff
    firestore (CSI Auto Indexing Disable and Delete)268 kB245 kB-22.7 kB (-8.5%)
    firestore (CSI Auto Indexing Enable)268 kB269 kB+704 B (+0.3%)
    firestore (Persistence)303 kB280 kB-22.8 kB (-7.5%)
    firestore (Query Cursors)238 kB237 kB-1.27 kB (-0.5%)
    firestore (Query)236 kB235 kB-1.27 kB (-0.5%)
    firestore (Read data once)224 kB223 kB-1.27 kB (-0.6%)
    firestore (Read Write w Persistence)321 kB298 kB-22.8 kB (-7.1%)
    firestore (Realtime updates)226 kB225 kB-1.27 kB (-0.6%)
    firestore (Transaction)204 kB203 kB-1.27 kB (-0.6%)
    firestore (Write data)204 kB203 kB-1.27 kB (-0.6%)
  • firebase

    TypeBase (7f78362)Merge (3c7cc8f)Diff
    firebase-compat.js779 kB757 kB-22.2 kB (-2.9%)
    firebase-firestore-compat.js341 kB319 kB-22.2 kB (-6.5%)
    firebase-firestore.js434 kB436 kB+2.07 kB (+0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4zPnF3MFaC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 4, 2024

Size Analysis Report 1

This report is too large (478,267 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xm1OYnCNkq.html

@dconeybe
Copy link
Contributor Author

dconeybe commented Jan 5, 2024

The changes in this PR have been merged into #7902. Therefore, I'm closing this PR.

@dconeybe dconeybe closed this Jan 5, 2024
@dconeybe dconeybe deleted the dconeybe/CsiTreeShake2 branch January 5, 2024 20:40
@firebase firebase locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants