Encode timestamp fraction according to the Proto3 JSON Specification. #8035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 370a5e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
dconeybe
requested changes
Feb 22, 2024
|
|
||
| // Pad the fraction out to 3, 6, or 9 digits | ||
| let microStr = ('000000000' + timestamp.nanoseconds).slice(-9); | ||
| while (microStr.endsWith('000')) { |
There was a problem hiding this comment.
Shouldn't endsWith() be startsWith()? By using endsWith(), isn't that loop effectively dividing the fraction by 1000 on each iteration?
There was a problem hiding this comment.
The loop trims "000" off the end. So 1.123000 becomes 1.123. This has the same numeric value but allows comparison of the date strings returned by Firestore backend, which also perform this truncation.
There was a problem hiding this comment.
What about backwards compatibility? Do we need to write a data migration to convert timestamps from the old format to the new format?
There was a problem hiding this comment.
We are persisting date strings from the backend, which already have the truncated format, so at least for this we don't need a migration. However, I'm running into some issues with edge cases and I think using the Proto3 JSON date format for comparison will not work.
|
After testing some edge cases, there are other issues with comparing these Proto3 JSON timestamp values. This approach will not work. Closing this PR for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK encodes a string representation of a timestamp for use as the key value in client side indexes. For this, and other reason, the SDK and Firestore backend must stringify timestamps identically.
Fixes: #8031