Remove apiVersion and location options #8124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsTest Logs |
Size Analysis Report 1Affected Products
Test Logs |
DellaBitta
reviewed
Apr 4, 2024
packages/vertexai/src/api.ts
Outdated
| app: FirebaseApp = getApp(), | ||
| options?: VertexOptions | ||
| ): Vertex { | ||
| export function getVertex(app: FirebaseApp = getApp()): Vertex { |
There was a problem hiding this comment.
should this be getVertexAI now?
There was a problem hiding this comment.
Will fix this in the merge with the other PR.
DellaBitta
reviewed
Apr 4, 2024
packages/vertexai/src/index.ts
Outdated
| // getImmediate for FirebaseApp will always succeed | ||
| const app = container.getProvider('app').getImmediate(); | ||
| const appCheckProvider = container.getProvider('app-check-internal'); | ||
| return new VertexService(app, appCheckProvider, { location }); | ||
| return new VertexService(app, appCheckProvider); |
There was a problem hiding this comment.
Will fix in the merge.
DellaBitta
approved these changes
Apr 4, 2024
ryanwilson
added a commit
that referenced
this pull request
May 2, 2024
Re-add the apiVersion and location options. Slight modification to the revert, will not re-add the placeholder test. This reverts commit bf7d2d8.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not intended to be available options for private preview release.
Also removed a test file that seems to just be a placeholder.