Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set package to public #8125

Merged
merged 3 commits into from Apr 4, 2024
Merged

Set package to public #8125

merged 3 commits into from Apr 4, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 4, 2024

  • Forgot to set package to public.

  • Prerelease adds a bunch of suffixes to the version number (prerelease tag, git hash), just extracting the first version number part. This should also work if it's not a prerelease and there's no suffixes. This check ignores the "never published" error from npm info if the version is 0.0.1 indicating that it's the first publish. We should probably implement something smarter going forward (first publish won't always be 0.0.1 probably).

Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: 7a91ce1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 4, 2024 20:18
@hsubox76 hsubox76 requested a review from a team as a code owner April 4, 2024 20:18
@hsubox76 hsubox76 requested a review from DellaBitta April 4, 2024 20:18
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 4, 2024

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (bf7d2d8)Merge (c06de8a)Diff
    browser?22.3 kB? (?)
    main?22.9 kB? (?)
    module?22.3 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OkLTAwyQi9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 4, 2024

@hsubox76 hsubox76 merged commit 8b70fc5 into ch-vertex-feature Apr 4, 2024
39 of 41 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-public branch April 4, 2024 21:07
@firebase firebase locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants