Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fixes blocking publish #8126

Merged
merged 2 commits into from Apr 5, 2024
Merged

Final fixes blocking publish #8126

merged 2 commits into from Apr 5, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 4, 2024

  • Forgot that our publish script looks for the npm publish token env var based on the package name, so it needs to be NPM_TOKEN_VERTEXAI
  • npm pkg fix so that package.json has the correctly formatted repo url string

Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: cdcc49e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 4, 2024 23:45
@hsubox76 hsubox76 requested a review from a team as a code owner April 4, 2024 23:45
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit acef5e3 into ch-vertex-feature Apr 5, 2024
38 of 42 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-pkgfix branch April 5, 2024 17:37
@firebase firebase locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants