New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GCS FileData in inference #8223
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (070e0cc) and merge commit (62d5047).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (070e0cc) and merge commit (62d5047).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good minus the stray yarn.lock change. I guess the design for now is to send the auth token on every request though it's only needed on requests that send fileData? I guess this is in anticipation of more auth gating in the future. We can discuss it further offline.
627f679
to
7a01455
Compare
dddb566
to
d24567b
Compare
7a01455
to
2c1c31b
Compare
This chain of branches is getting a bit messy- I'm just putting this PR out so it can be reviewed :)
This PR follows #8216, and uses Firebase Authorization tokens to allow users to pass URLs in
generateContent
to GS resources that are secured by Firebase Security Rules.This currently works against the production backend. I live tested in a React application configured with Firebase auth, storage, and vertexai.
Live tested using the following:
Storage rules:
Test cases:
Sample request payload: