Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressed comments #8244

Merged
merged 3 commits into from
May 13, 2024
Merged

Addressed comments #8244

merged 3 commits into from
May 13, 2024

Conversation

maneesht
Copy link
Contributor

No description provided.

@maneesht maneesht requested a review from a team as a code owner May 13, 2024 17:41
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 213d18a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maneesht maneesht merged commit aa08c92 into dataconnect May 13, 2024
15 of 22 checks passed
@maneesht maneesht deleted the mtewani/address-comments branch May 13, 2024 17:43
@maneesht maneesht restored the mtewani/address-comments branch May 13, 2024 17:45
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (81ee516)Merge (6cde031)Diff
    browser15.9 kB16.1 kB+177 B (+1.1%)
    esm517.9 kB18.1 kB+183 B (+1.0%)
    main19.9 kB20.0 kB+191 B (+1.0%)
    module15.9 kB16.1 kB+177 B (+1.1%)

  • firebase

    TypeBase (81ee516)Merge (6cde031)Diff
    firebase-data-connect.js13.9 kB14.0 kB+144 B (+1.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/F5DAu648eI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • DataConnect

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.25 kB9.38 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.28 kB9.41 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • FirebaseAuthProvider

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.26 kB9.39 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • MUTATION_STR

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size?9.40 kB? (?)
      size-with-ext-deps?27.3 kB? (?)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      functions?

      12 dependencies

      addToken
compareDates
dcFetch
getRefSerializer
logDebug
logError
parseOptions
registerDataConnect
setEncoder
setIfNotExists
setSDKVersion
urlBuilder

      		?
      classes?

      DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

      		?
      variables?

      12 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
MUTATION_STR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      		?
      enums??

      External Dependency

      ModuleBase (81ee516)Merge (6cde031)Diff
      @firebase/app?

      SDK_VERSION
_registerComponent
_removeServiceInstance
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/logger?

      Logger

      		?
      @firebase/util?

      FirebaseError

      		?

    • MutationManager

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.26 kB9.39 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • QUERY_STR

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size?9.38 kB? (?)
      size-with-ext-deps?27.3 kB? (?)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      functions?

      12 dependencies

      addToken
compareDates
dcFetch
getRefSerializer
logDebug
logError
parseOptions
registerDataConnect
setEncoder
setIfNotExists
setSDKVersion
urlBuilder

      		?
      classes?

      DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

      		?
      variables?

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      		?
      enums??

      External Dependency

      ModuleBase (81ee516)Merge (6cde031)Diff
      @firebase/app?

      SDK_VERSION
_registerComponent
_removeServiceInstance
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/logger?

      Logger

      		?
      @firebase/util?

      FirebaseError

      		?

    • SOURCE_CACHE

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.25 kB9.38 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • SOURCE_SERVER

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.26 kB9.38 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • connectDataConnectEmulator

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.34 kB9.47 kB+129 B (+1.4%)
      size-with-ext-deps27.3 kB27.4 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • executeMutation

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.33 kB9.46 kB+129 B (+1.4%)
      size-with-ext-deps27.3 kB27.4 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • executeQuery

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.32 kB9.45 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.4 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • getDataConnect

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.74 kB9.87 kB+129 B (+1.3%)
      size-with-ext-deps34.8 kB34.9 kB+131 B (+0.4%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • mutationRef

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.37 kB9.50 kB+129 B (+1.4%)
      size-with-ext-deps27.3 kB27.4 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      12 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
MutationStr
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      12 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
MUTATION_STR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + MUTATION_STR
+ QUERY_STR
- MutationStr
- QueryStr

    • parseOptions

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.25 kB9.38 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • queryRef

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.37 kB9.50 kB+129 B (+1.4%)
      size-with-ext-deps27.3 kB27.4 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • setLogLevel

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.28 kB9.41 kB+129 B (+1.4%)
      size-with-ext-deps27.2 kB27.3 kB+131 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • subscribe

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size10.3 kB10.4 kB+131 B (+1.3%)
      size-with-ext-deps35.3 kB35.4 kB+133 B (+0.4%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • terminate

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.28 kB9.41 kB+136 B (+1.5%)
      size-with-ext-deps27.2 kB27.3 kB+138 B (+0.5%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

    • toQueryRef

      Size

      TypeBase (81ee516)Merge (6cde031)Diff
      size9.94 kB10.1 kB+129 B (+1.3%)
      size-with-ext-deps35.0 kB35.1 kB+131 B (+0.4%)

      Dependency

      TypeBase (81ee516)Merge (6cde031)Diff
      variables

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QueryStr
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      11 dependencies

      Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      + QUERY_STR
- QueryStr

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/heaff5ycwa.html

@firebase firebase locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maneesht @google-oss-bot