Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert supported mimetypes to be bullet points #8270

Merged
merged 4 commits into from
May 30, 2024

Conversation

dlarocque
Copy link
Contributor

Convert supported mimetypes in the reference documentation to be bulleted.

@dlarocque dlarocque requested a review from egilmorez May 29, 2024 19:12
@dlarocque dlarocque requested review from a team as code owners May 29, 2024 19:12
Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: 5fd5527

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 29, 2024

Changeset File Check ⚠️

  • Changeset formatting error in following file:%0A %0A Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.%0A If this change doesn't need a release, run `changeset add --empty`.%0A %0A

@dlarocque dlarocque requested review from a team as code owners May 29, 2024 19:19
@dlarocque dlarocque requested a review from DellaBitta May 29, 2024 19:19
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 29, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 29, 2024

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel!

Would it be possible to test the generation, and then put a link to the staged/rendered output in the PR description?

I often do that as "Staged internally at ."

@dlarocque
Copy link
Contributor Author

dlarocque commented May 29, 2024

Thanks Daniel!

Would it be possible to test the generation, and then put a link to the staged/rendered output in the PR description?

I often do that as "Staged internally at ."

I had trouble getting the bulleted list to render correctly, so I converted it to be a full sentence since there were only two bullets.
This change is staged at https://firebase.devsite.corp.google.com/docs/reference/js (internal)

If you prefer a bulleted list for this, could you share an example of how to get it to render correctly?

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Bullets not essential, thanks!

@@ -0,0 +1,2 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need a changeset for documentation changes.

@dlarocque dlarocque merged commit 5e16ccf into master May 30, 2024
28 of 29 checks passed
@dlarocque dlarocque deleted the dlarocque/vertexai-refdocs branch May 30, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants