Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Heartbeat Name for Data Connect #8283

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Updated Heartbeat Name for Data Connect #8283

merged 2 commits into from
Jul 3, 2024

Conversation

maneesht
Copy link
Contributor

Replaced fire-connect with fire-data-connect to match other package names.

@maneesht maneesht requested review from aashishpatil-g and a team as code owners May 31, 2024 17:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 79cbcf3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maneesht maneesht changed the base branch from master to dataconnect May 31, 2024 17:36
@github-actions GitHub Actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:%0A %0A Package "@firebase/data-connect" must depend on the current version of "@firebase/auth-interop-types": "0.2.3" vs "0.2.2"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/component": "0.6.7" vs "0.6.6"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/logger": "0.4.2" vs "0.4.1"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/util": "1.9.6" vs "1.9.5"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/app": "0.10.5" vs "0.10.2"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/auth-interop-types": "0.2.3" vs "0.2.2"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/component": "0.6.7" vs "0.6.6"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/logger": "0.4.2" vs "0.4.1"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/util": "1.9.6" vs "1.9.5"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/app": "0.10.5" vs "0.10.2"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/auth-interop-types": "0.2.3" vs "0.2.2"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/component": "0.6.7" vs "0.6.6"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/logger": "0.4.2" vs "0.4.1"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/util": "1.9.6" vs "1.9.5"%0A Package "@firebase/data-connect" must depend on the current version of "@firebase/app": "0.10.5" vs "0.10.2"%0A Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.%0A If this change doesn't need a release, run `changeset add --empty`.%0A %0A

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 31, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (01ca9df)Merge (eb9a51b)Diff
    browser18.2 kB18.2 kB+5 B (+0.0%)
    esm523.8 kB23.8 kB+5 B (+0.0%)
    main24.8 kB24.8 kB+5 B (+0.0%)
    module18.2 kB18.2 kB+5 B (+0.0%)

  • bundle

    46 size changes

    TypeBase (01ca9df)Merge (eb9a51b)Diff
    analytics (logEvent)44.5 kB44.5 kB+5 B (+0.0%)
    app-check (CustomProvider)37.4 kB37.4 kB+5 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)39.9 kB39.9 kB+5 B (+0.0%)
    app-check (ReCaptchaV3Provider)39.9 kB39.9 kB+5 B (+0.0%)
    auth (Anonymous)76.1 kB76.1 kB+5 B (+0.0%)
    auth (EmailAndPassword)84.4 kB84.4 kB+5 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)103 kB103 kB+5 B (+0.0%)
    auth (GooglePopup)101 kB101 kB+5 B (+0.0%)
    auth (GoogleRedirect)101 kB101 kB+5 B (+0.0%)
    auth (Phone)86.7 kB86.8 kB+5 B (+0.0%)
    database (Append to a list of data)149 kB149 kB+5 B (+0.0%)
    database (Filtering data)148 kB148 kB+5 B (+0.0%)
    database (Listen for child events)164 kB164 kB+5 B (+0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB+5 B (+0.0%)
    database (Listen for value events)164 kB164 kB+5 B (+0.0%)
    database (Read data once)164 kB164 kB+5 B (+0.0%)
    database (Save data as transactions)166 kB166 kB+5 B (+0.0%)
    database (Sort data)150 kB150 kB+5 B (+0.0%)
    database (Write data)148 kB148 kB+5 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)268 kB268 kB+5 B (+0.0%)
    firestore (CSI Auto Indexing Enable)268 kB268 kB+5 B (+0.0%)
    firestore (Persistence)303 kB303 kB+5 B (+0.0%)
    firestore (Query Cursors)240 kB240 kB+5 B (+0.0%)
    firestore (Query)238 kB238 kB+5 B (+0.0%)
    firestore (Read data once)226 kB226 kB+5 B (+0.0%)
    firestore (Read Write w Persistence)322 kB322 kB+5 B (+0.0%)
    firestore (Realtime updates)228 kB228 kB+5 B (+0.0%)
    firestore (Transaction)205 kB205 kB+5 B (+0.0%)
    firestore (Write data)205 kB205 kB+5 B (+0.0%)
    firestore-lite (Query Cursors)89.9 kB89.9 kB+5 B (+0.0%)
    firestore-lite (Query)86.0 kB86.0 kB+5 B (+0.0%)
    firestore-lite (Read data once)62.2 kB62.2 kB+5 B (+0.0%)
    firestore-lite (Transaction)87.1 kB87.1 kB+5 B (+0.0%)
    firestore-lite (Write data)71.7 kB71.7 kB+5 B (+0.0%)
    functions (call)31.9 kB31.9 kB+5 B (+0.0%)
    messaging (send + receive)46.9 kB46.9 kB+5 B (+0.0%)
    performance (trace)51.8 kB51.8 kB+5 B (+0.0%)
    remote-config (getAndFetch)46.3 kB46.3 kB+5 B (+0.0%)
    storage (getBytes)42.1 kB42.1 kB+5 B (+0.0%)
    storage (getDownloadURL)44.1 kB44.1 kB+5 B (+0.0%)
    storage (getMetadata)43.6 kB43.6 kB+5 B (+0.0%)
    storage (list + listAll)43.0 kB43.0 kB+5 B (+0.0%)
    storage (updateMetadata)43.8 kB43.9 kB+5 B (+0.0%)
    storage (uploadBytes)48.7 kB48.7 kB+5 B (+0.0%)
    storage (uploadBytesResumable)58.7 kB58.7 kB+5 B (+0.0%)
    storage (uploadString)48.9 kB48.9 kB+5 B (+0.0%)

  • firebase

    TypeBase (01ca9df)Merge (eb9a51b)Diff
    firebase-app-compat.js31.5 kB31.5 kB+5 B (+0.0%)
    firebase-app.js102 kB102 kB+5 B (+0.0%)
    firebase-compat.js786 kB786 kB+5 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js93.4 kB93.4 kB+5 B (+0.0%)
    firebase-performance-standalone-compat.js70.4 kB70.4 kB+5 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZA6sk2R2Bl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 31, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (156,623 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uj76p8bOnX.html

@maneesht maneesht merged commit 842463d into dataconnect Jul 3, 2024
34 of 39 checks passed
@maneesht maneesht deleted the mtewani/add-heartbeat-dc branch July 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maneesht @google-oss-bot @hsubox76 @aashishpatil-g