Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsec script to all packages #8285

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add tsec script to all packages #8285

merged 2 commits into from
Jun 4, 2024

Conversation

dlarocque
Copy link
Contributor

Added the yarn trusted-type-check script to all packages. The script runs tsec to report possible security issues.

Here is a sample output from the script, showing all warnings that we have to fix using safevalues: (internal) https://paste.googleplex.com/6754875962818560

Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: aae1e3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dlarocque dlarocque marked this pull request as draft May 31, 2024 20:41
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:%0A %0A Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.%0A If this change doesn't need a release, run `changeset add --empty`.%0A %0A

@dlarocque dlarocque marked this pull request as ready for review May 31, 2024 20:47
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 31, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 31, 2024

@hsubox76
Copy link
Contributor

hsubox76 commented Jun 4, 2024

Changeset File Check ⚠️

  • Changeset formatting error in following file:%0A %0A Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.%0A If this change doesn't need a release, run `changeset add --empty`.%0A %0A

As a tangent we have to figure out why this keeps happening, it should no-op in this case. The changeset bot is already handling the "no changeset" case.

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, once we get the errors fixed we should add this to CI - not sure if it should have its own workflow or be grouped with something else. How long does it take to run?

@dlarocque dlarocque merged commit 436331a into master Jun 4, 2024
40 of 42 checks passed
@dlarocque dlarocque deleted the dlarocque/g3-sanitize branch June 4, 2024 21:36
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants