Skip to content

Commit

Permalink
Added condition to change value of port when options.port value is sp…
Browse files Browse the repository at this point in the history
…ecified. (#5531)
  • Loading branch information
aalej committed Feb 23, 2023
1 parent c05b9cd commit 07cc578
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Allow configuration of the Cloud Function generated for full-stack web frameworks (#5504)
- Fixes bug where passing `--port` flag in `functions:shell` does not set which port to emulate functions (#5521)
- Improve error message during deploy when given invalid hosting rewrite rule (#5533)
- Generate ESM-compatible SSR function for web frameworks (#5540)
4 changes: 4 additions & 0 deletions src/functionsShellCommandAction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ export const actionFunction = async (options: Options) => {
// If the port was not set by the --port flag or determined from 'firebase.json', just scan
// up from 5000
let port = 5000;
if (typeof options.port === "number") {
port = options.port;
}

const functionsInfo = remoteEmulators[Emulators.FUNCTIONS];
if (functionsInfo) {
utils.logLabeledWarning(
Expand Down

0 comments on commit 07cc578

Please sign in to comment.