Skip to content

Commit

Permalink
Rename emulator to Dataconnect (#869)
Browse files Browse the repository at this point in the history
The emulator was renamed in a previous commit, but it appears that there were some leftovers.
  • Loading branch information
rrousselGit committed Feb 28, 2024
1 parent 5df134e commit 0ce5e5b
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion firebase-vscode/common/messaging/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const DEFAULT_EMULATOR_UI_SELECTIONS: EmulatorUiSelections = {
projectId: "demo-something",
importStateFolderPath: "",
exportStateOnExit: false,
mode: "firemat",
mode: 'dataconnect',
debugLogging: false,
};

Expand Down
2 changes: 1 addition & 1 deletion firebase-vscode/common/messaging/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ export interface EmulatorUiSelections {
firebaseJsonPath?: string;
importStateFolderPath?: string;
exportStateOnExit: boolean;
mode: "hosting" | "all" | "firemat";
mode: "hosting" | "all" | "dataconnect";
debugLogging: boolean;
}
4 changes: 2 additions & 2 deletions firebase-vscode/src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,8 @@ export async function emulatorsStart(
const only =
emulatorUiSelections.mode === "hosting"
? "hosting"
: emulatorUiSelections.mode === "firemat"
? "firemat,auth"
: emulatorUiSelections.mode === "dataconnect"
? `${Emulators.DATACONNECT},${Emulators.AUTH}`
: "";
const commandOptions = await getCommandOptions(undefined, {
...currentOptions.value,
Expand Down
3 changes: 2 additions & 1 deletion firebase-vscode/src/core/emulators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
ExtensionToWebviewParamsMap,
} from "../../common/messaging/protocol";
import { firebaseRC } from "./config";
import { EmulatorUiSelections } from "../messaging/types";

export class EmulatorsController implements Disposable {
constructor(private broker: ExtensionBrokerImpl) {
Expand Down Expand Up @@ -133,7 +134,7 @@ export class EmulatorsController implements Disposable {
*/
private getProjectIdForMode(
projectId: string | undefined,
mode: "all" | "hosting" | "firemat",
mode: EmulatorUiSelections["mode"],
): string {
if (!projectId) {
return "demo-something";
Expand Down
2 changes: 1 addition & 1 deletion firebase-vscode/src/test/utils/page_objects/sidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class FirebaseSidebar {
}

get startEmulatorBtn() {
return $("vscode-button=Launch FireMAT emulator");
return $("vscode-button=Launch Data Connect emulator");
}

get stopEmulatorBtn() {
Expand Down
2 changes: 1 addition & 1 deletion firebase-vscode/webviews/components/EmulatorPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export function EmulatorPanel({
onClick={() => launchEmulators()}
disabled={showEmulatorProgressIndicator}
>
Launch FireMAT emulator
Launch Data Connect emulator
</VSCodeButton>
)}
</PanelSection>
Expand Down

0 comments on commit 0ce5e5b

Please sign in to comment.