Skip to content

Commit

Permalink
Fix/next js predeploy hooks (#5288)
Browse files Browse the repository at this point in the history
* Fix predeploy hooks not running for framework deploy

Co-authored-by: SirFreakness <louisscheers@gmail.com>
  • Loading branch information
jamesdaniels and freakness committed Dec 2, 2022
1 parent d59f265 commit 10e022b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -3,4 +3,5 @@
- Fix bug in auth emulator in which createdAt was not set for signInWithIdp new users. (#5203)
- Default to --no-localhost when calling login from Google Cloud Workstations
- Support the x-goog-api-key header in auth emulator. (#5249)
- Fix bug in deploying web frameworks when a predeploy hook was configured in firebase.json (#5199)
- Fix bug where function deployments using --only filter sometimes failed deployments. (#5280)
2 changes: 1 addition & 1 deletion src/deploy/lifecycleHooks.ts
Expand Up @@ -48,7 +48,7 @@ function getChildEnvironment(target: string, overallOptions: any, config: any) {
let resourceDir;
switch (target) {
case "hosting":
resourceDir = overallOptions.config.path(config.public);
resourceDir = overallOptions.config.path(config.public ?? config.source);
break;
case "functions":
resourceDir = overallOptions.config.path(config.source);
Expand Down

0 comments on commit 10e022b

Please sign in to comment.