Fix bug where Custom Event channels weren't automatically crated on f…

…unction deploys. (#5700) Deploying Eventarc Custom Event Function deploy fails for projects that doesn't have `"projects/cf3-tq-sample/locations/us-central1/channels/firebase"` channel. Fixes bug introduced in #5443.
firebase · Apr 20, 2023 · 18c03e7 · 18c03e7
1 parent bd0dc4d
commit 18c03e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
 - Releases Firestore Emulator 1.17.1
   - Propagates page token from ListDocumentsResponse to GetOrListDocumentsResponse in Firestore emulator.
 - Fixes an issue where Secret Manager secrets were tagged incorrectly (#5704).
+- Fix bug where Custom Event channels weren't automatically crated on function deploys (#5700)
diff --git a/src/gcp/eventarc.ts b/src/gcp/eventarc.ts
@@ -53,7 +53,7 @@ const client = new Client({
  * Gets a Channel.
  */
 export async function getChannel(name: string): Promise<Channel | undefined> {
-  const res = await client.get<Channel>(name);
+  const res = await client.get<Channel>(name, { resolveOnHTTPError: true });
   if (res.status === 404) {
     return undefined;
   }