Skip to content

Commit

Permalink
Replace dependency on broken node-unzipper with native zlib (#5714)
Browse files Browse the repository at this point in the history
* Replace dependency on broken node-unzipper with native zlib

Fixes:
#5614
#5677
firebase/firebase-tools-ui#939
firebase/firebase-tools-ui#940

* remove unused broken.zip fixture

* add changelog record

* fix timing out test

* fix use operating system file delimiter

* addressing code review comments from @joehan

* better support for Windows path separators

TODO: remove console logs after @christhompsongoogle tries it out.

* addressing code review comments from @joehan

* Add support for zip files that use signed data descriptors instead of a full entry header

* Formats, fixes uneeded async/await

* Remove unnecessary handling for empty files

* Remove console.log

---------

Co-authored-by: joehan <joehanley@google.com>
  • Loading branch information
Durisvk and joehan committed May 2, 2023
1 parent e3d1c99 commit 19a8384
Show file tree
Hide file tree
Showing 32 changed files with 447 additions and 316 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
- Added more helpful error messages for the Firebase Hosting GitHub Action (#5749)
- Upgrade Firestore emulator to 1.17.4
- Web Frameworks will no longer try to deploy unsupported versions of NodeJS to Cloud Functions (#5733)
- Fixes bug where emulators would not start correctly due to corrupted ZIP files. (#5614, #5677)
- Adding experimental support for deploying Flutter Web applications to Firebase Hosting (#5332)
- Release Emulator Suite UI v1.11.6 (#5769)
- Adds function emulator support for v2 firestore triggers (#5685)
Expand Down

0 comments on commit 19a8384

Please sign in to comment.