Skip to content

Commit

Permalink
Fix bug where emulator didn't consider .env.local when discovering tr…
Browse files Browse the repository at this point in the history
…iggers. (#5477)

Fixes #5219.

Note that the actual fix is a one-liner. I'm adding basic integration test for dotenv and params support for the emulator.
  • Loading branch information
taeold committed Jan 31, 2023
1 parent 020c96b commit 4408aeb
Show file tree
Hide file tree
Showing 5 changed files with 824 additions and 594 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
- Pass `trailingSlash` from Next.js config to `firebase.json` (#5445)
- Don't use Next.js internal redirects for the backend test (#5445)
- Fix issue where pnpm support broke for function emulation and deployment. (#5467)
- Fix bug where .env.local files were not picked up during function emulation. (#5477)
20 changes: 9 additions & 11 deletions scripts/emulator-tests/functions/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/emulator-tests/functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dependencies": {
"express": "^4.18.1",
"firebase-admin": "^11.5.0",
"firebase-functions": "^3.22.0"
"firebase-functions": "^4.0.0"
},
"engines": {
"node": "16"
Expand Down

0 comments on commit 4408aeb

Please sign in to comment.