Switching a few more places to getters (#6914)

Co-authored-by: Harold Shen <hlshen@google.com>
firebase · Mar 26, 2024 · 4c1bd42 · 4c1bd42
1 parent 6950829
commit 4c1bd42
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/api.ts b/src/api.ts
@@ -35,11 +35,6 @@ export const authOrigin = () =>
   utils.envOverride("FIREBASE_AUTH_URL", "https://accounts.google.com");
 export const consoleOrigin = () =>
   utils.envOverride("FIREBASE_CONSOLE_URL", "https://console.firebase.google.com");
-export const deployOrigin = () =>
-  utils.envOverride(
-    "FIREBASE_DEPLOY_URL",
-    utils.envOverride("FIREBASE_UPLOAD_URL", "https://deploy.firebase.com"),
-  );
 export const dynamicLinksOrigin = () =>
   utils.envOverride("FIREBASE_DYNAMIC_LINKS_URL", "https://firebasedynamiclinks.googleapis.com");
 export const dynamicLinksKey = () =>

diff --git a/src/gcp/devConnect.ts b/src/gcp/devConnect.ts
@@ -254,5 +254,5 @@ export async function getGitRepositoryLink(
  * Returns email associated with the Developer Connect Service Agent
  */
 export function serviceAgentEmail(projectNumber: string): string {
-  return `service-${projectNumber}@${developerConnectP4SAOrigin}`;
+  return `service-${projectNumber}@${developerConnectP4SAOrigin()}`;
 }
diff --git a/src/gcp/identityPlatform.ts b/src/gcp/identityPlatform.ts
@@ -5,7 +5,7 @@ import { Client } from "../apiv2";
 const API_VERSION = "v2";
 
 const adminApiClient = new Client({
-  urlPrefix: identityOrigin + "/admin",
+  urlPrefix: identityOrigin() + "/admin",
   apiVersion: API_VERSION,
 });
 

diff --git a/src/init/features/hosting/github.ts b/src/init/features/hosting/github.ts
@@ -206,7 +206,7 @@ export async function initGitHub(setup: Setup): Promise<void> {
     `Visit this URL to revoke authorization for the Firebase CLI GitHub OAuth App:`,
   );
   logger.info(
-    bold(underline(`https://github.com/settings/connections/applications/${githubClientId}`)),
+    bold(underline(`https://github.com/settings/connections/applications/${githubClientId()}`)),
   );
   logLabeledBullet("Action required", `Push any new workflow file(s) to your repo`);
 }
@@ -442,7 +442,9 @@ async function promptForRepo(
             );
             logger.info(
               bold(
-                underline(`https://github.com/settings/connections/applications/${githubClientId}`),
+                underline(
+                  `https://github.com/settings/connections/applications/${githubClientId()}`,
+                ),
               ),
             );
             logger.info();