Fix incorrect warnings when emulating extensions with httpsTriggers (#…

…6055)
firebase · Jun 28, 2023 · 4db12d2 · 4db12d2
1 parent 197506a
commit 4db12d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
 - Increased extension instance create poll timeout to 1h to match backend (#5969).
 - Refactored `ext:install` to use the latest extension metadata. (#5997)
+- Fixed issue where missing trigger warnings would be wrongly displayed when emulating extensions with HTTPS triggers. (#6055)
 - Normalized extension root path before usage in `ext:dev:upload`. (#6054)
diff --git a/src/extensions/emulator/triggerHelper.ts b/src/extensions/emulator/triggerHelper.ts
@@ -77,7 +77,8 @@ export function functionResourceToEmulatedTriggerDefintion(
     proto.convertIfPresent(etd, properties, "timeoutSeconds", "timeout", proto.secondsFromDuration);
     proto.convertIfPresent(etd, properties, "regions", "location", (str: string) => [str]);
     proto.copyIfPresent(etd, properties, "availableMemoryMb");
-    if (properties.httpsTrigger) {
+    if (properties.httpsTrigger !== undefined) {
+      // Need to explcitly check undefined since {} is falsey
       etd.httpsTrigger = properties.httpsTrigger;
     }
     if (properties.eventTrigger) {