Address feedback.

firebase · Sep 20, 2017 · 5232976 · 5232976
1 parent 7976470
commit 5232976
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/deploy/storage/deploy.js b/lib/deploy/storage/deploy.js
@@ -14,7 +14,7 @@ module.exports = function(context, options) {
 
   return gcp.storage.buckets.getDefault(options.project).then(function(defaultBucket) {
     if (!defaultBucket) {
-      return utils.reject('Unable to locate your default bucket. Please visit the storage panel in the Firebase console to ensure provisioning.');
+      return utils.reject('Unable to locate your default bucket. Please visit the "Storage" panel in the Firebase console and check for errors.');
     }
 
     context.storage.defaultBucket = defaultBucket;

diff --git a/lib/gcp/rules.js b/lib/gcp/rules.js
@@ -4,6 +4,8 @@ var api = require('../api');
 var logger = require('../logger');
 var utils = require('../utils');
 
+var API_VERSION = 'v1';
+
 function _handleErrorResponse(response) {
   if (response.body && response.body.error) {
     return utils.reject(response.body.error, {code: 2});
@@ -21,7 +23,7 @@ function _handleErrorResponse(response) {
 function createRuleset(projectId, files) {
   var payload = {source: {files: files}};
 
-  return api.request('POST', '/v1/projects/' + projectId + '/rulesets', {
+  return api.request('POST', '/' + API_VERSION + '/projects/' + projectId + '/rulesets', {
     auth: true,
     data: payload,
     origin: api.rulesOrigin
@@ -47,7 +49,7 @@ function createRelease(projectId, rulesetName, releaseName) {
     rulesetName: rulesetName
   };
 
-  return api.request('POST', '/v1/projects/' + projectId + '/releases', {
+  return api.request('POST', '/' + API_VERSION + '/projects/' + projectId + '/releases', {
     auth: true,
     data: payload,
     origin: api.rulesOrigin
@@ -73,7 +75,7 @@ function updateRelease(projectId, rulesetName, releaseName) {
     rulesetName: rulesetName
   };
 
-  return api.request('PUT', '/v1/projects/' + projectId + '/releases/' + releaseName, {
+  return api.request('PUT', '/' + API_VERSION + '/projects/' + projectId + '/releases/' + releaseName, {
     auth: true,
     data: payload,
     origin: api.rulesOrigin
@@ -96,7 +98,7 @@ function updateOrCreateRelease(projectId, rulesetName, releaseName) {
 }
 
 function testRuleset(projectId, files) {
-  return api.request('POST', '/v1/projects/' + encodeURIComponent(projectId) + ':test', {
+  return api.request('POST', '/' + API_VERSION + '/projects/' + encodeURIComponent(projectId) + ':test', {
     origin: api.rulesOrigin,
     data: {
       source: {files: files}