Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master'
Browse files Browse the repository at this point in the history
  • Loading branch information
bkendall committed Nov 1, 2018
2 parents a0fd409 + 7458820 commit 5482a3a
Showing 1 changed file with 29 additions and 5 deletions.
34 changes: 29 additions & 5 deletions src/commands/serve.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"use strict";

var clc = require("cli-color");
var _ = require("lodash");

var Command = require("../command");
var logger = require("../logger");
Expand All @@ -13,12 +14,26 @@ var filterTargets = require("../filterTargets");
var getProjectNumber = require("../getProjectNumber");
var previews = require("../previews");

var VALID_EMULATORS = [];
var VALID_TARGETS = ["functions", "hosting"];

if (previews.emulators) {
VALID_EMULATORS = ["database", "firestore"];
VALID_TARGETS = ["functions", "hosting", "database", "firestore"];
}

var filterOnlyEmulators = only => {
if (!only) {
return [];
}
return _.intersection(
VALID_EMULATORS,
only.split(",").map(opt => {
return opt.split(":")[0];
})
);
};

module.exports = new Command("serve")
.description("start a local server for your static assets")
.option("-p, --port <port>", "the port on which to listen (default: 5000)", 5000)
Expand All @@ -31,11 +46,20 @@ module.exports = new Command("serve")
"--except <targets>",
"serve all except specified targets (valid targets are: " + VALID_TARGETS.join(", ") + ")"
)
.before(requireConfig)
.before(requirePermissions)
.before(checkDupHostingKeys)
.before(getProjectNumber)
.action(function(options) {
.before(options => {
if (filterOnlyEmulators(options.only).length > 0) {
return Promise.resolve();
}
return requireConfig(options)
.then(() => requirePermissions(options))
.then(() => checkDupHostingKeys(options))
.then(() => getProjectNumber(options));
})
.action(options => {
options.targets = filterOnlyEmulators(options.only);
if (options.targets.length > 0) {
return serve(options);
}
if (options.config) {
logger.info();
logger.info(
Expand Down

0 comments on commit 5482a3a

Please sign in to comment.